🚀 feat: added accordion button props so we can customize type #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,9 +221,13 @@ const Accordion = ({ | |||
| disabled={disabled} | |||
| onClick={() => { | |||
| setOpen(o => !o); | |||
| if (headerProps.onClick) { | |||
There was a problem hiding this comment.
Suggested change
| if (headerProps.onClick) { | |
| if (typeof headerProps.onClick === 'function') { |
There was a problem hiding this comment.
Updated @MicaelRodrigues
tiagogomes772
force-pushed
the
fix/add-accordion-button-props
branch
from
f08119b to
a8ac9ef
Compare
|
Comment on lines
+224
to
+226
| if (typeof headerProps.onClick === 'function') { | ||
| headerProps.onClick(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (typeof headerProps.onClick === 'function') { | |
| headerProps.onClick(); | |
| } | |
| headerProps.onClick?.(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📄
The goal of this PR is to help solve an issue related with the type of the button inside forms.
The bug we have is trigger everytime we click on the accordion header (button) that causes the form to be submitted.
Behaviour we don't want. To avoid this I added the props of the button so we can modify it's type.
Also added the onClick function in case someone in the future requires to track the event fired by the button, this can be removed since we don't need it at the moment and just thought it was a nice addition.
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Checklist: 🔍
Screenshots 📸
Screen.Recording.2024-06-18.at.08.42.05.mov
[Upload your screenshots here]