Merge pull request #115 from gympass/bugfix

fix: panic on Ingresses with no HTTP field on rules

Makefile

@@ -199,7 +199,7 @@ $(CONTROLLER_GEN): $(LOCALBIN)
 .PHONY: envtest
 envtest: $(ENVTEST) ## Download envtest-setup locally if necessary.
 $(ENVTEST): $(LOCALBIN)
-	test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@latest
+	test -s $(LOCALBIN)/setup-envtest || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20240208111015-5923139bc5bd
 
 .PHONY: bundle
 bundle: manifests kustomize ## Generate bundle manifests and metadata, then validate generated files.

internal/k8s/ingress.go

@@ -265,6 +265,9 @@ func pathsForViewerFunction(ing *networkingv1.Ingress, fnARN string) []Path {
 
 	var paths []Path
 	for _, rule := range rules {
+		if rule.HTTP == nil {
+			continue
+		}
 		for _, p := range rule.HTTP.Paths {
 			newPath := Path{
 				PathPattern:          p.Path,
@@ -283,6 +286,9 @@ func pathsForFunctionAssociations(ctx context.Context, ing *networkingv1.Ingress
 
 	var paths []Path
 	for _, rule := range rules {
+		if rule.HTTP == nil {
+			continue
+		}
 		for _, p := range rule.HTTP.Paths {
 			newPath := Path{
 				PathPattern: p.Path,

internal/k8s/validation.go

@@ -59,6 +59,9 @@ func ValidateIngressFunctionAssociations(ing *networkingv1.Ingress) error {
 func ingressPaths(ing *networkingv1.Ingress) []string {
 	var paths []string
 	for _, r := range ing.Spec.Rules {
+		if r.HTTP == nil {
+			continue
+		}
 		for _, p := range r.HTTP.Paths {
 			paths = append(paths, p.Path)
 		}