Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ligo.skymap 2.1.1 #5057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpsinger
Copy link
Contributor

@lpsinger lpsinger commented Feb 23, 2025

Standard information about the request

This is a: dependency update

Motivation

This version, and later versions, are compatible with both Numpy 1.x and 2.x.

Contents

Links to any issues or associated PRs

Testing performed

Additional notes

  • The author of this pull request confirms they will adhere to the code of conduct

This version, and later versions, are compatible with both
Numpy 1.x and 2.x.
@lpsinger lpsinger requested a review from ahnitz February 23, 2025 17:44
@lpsinger
Copy link
Contributor Author

Right, this will fail now because ligo.skymap conforms to SPEC 0 so it has dropped support for Python 3.9.

@ahnitz
Copy link
Member

ahnitz commented Feb 23, 2025

@lpsinger That's something you and @titodalcanton will likely need to discuss. As far as I know, 3.9 is till required to be supported for the low latency analysis in pycbc. I'm assigning him to review.

@ahnitz ahnitz requested review from titodalcanton and removed request for ahnitz February 23, 2025 20:41
@ahnitz
Copy link
Member

ahnitz commented Feb 23, 2025

@titodalcanton What is the plan for moving pycbc live off of 3.9? Can we drop 3.9 in pycbc (at least for testing if not officially).

@titodalcanton
Copy link
Contributor

titodalcanton commented Feb 24, 2025

We found that moving away from 3.9 requires some changes related to MPI for PyCBC Live at CIT, and these potentially affect the latency, or at least, they lead to some behavior that we do not understand yet. So we decided to continue with 3.9 for the time being and revisit the transition to something like 3.12 once some of the current priorities start winding down. We may get to that during the upcoming commissioning break.

Also note that we also use 3.9 for the LVK virtualenvs, i.e. the current offline analyses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants