Changes for v2.3.10 #5044
Changes for v2.3.10 #5044
Conversation
* Add compressed waveforms to bank workflow * Allolw plotting script to use any bank conversion parameter * Some fixes to allow the joined bank to be plotted * Use inference's parameter labels: they are available and mostly good * Add mismatch to plotting, make some tweaks * some tidying * thinko * Try to make the CI workflow run * Fix do-not-compress default * Use different examples in compress bank workflow * Proper name for the github workflow * Thinko * python shebang in compression workflow script * minor edits * move to readily-available waveform * TRy IMRPhenomD instead * revert change to workflow.core * Warn for KeyError in get_decompressed_waveform * Fix issue with if get_decompressed_waveform raised a ValueError
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
|
Still need:
|
|
Here's the PR #5052 to incorporate the FAR plot in the workflow. |
| for i in range( 0, self.num_banks): | ||
| curr_tag = 'bank%d' %(i) |
There was a problem hiding this comment.
@GarethCabournDavies I'm worried about including this change on v2.3.10 as it breaks the ability to reuse files (in a bad way, as pegasus gets confused by reusing a bunch of random files in a workflow which isn't well mapped to the workflow graph and so takes over a day to plan). Will it break anything if I revert this?
There was a problem hiding this comment.
Line 347 of tmpltbank.py is linked and so that would need changed as well.
I don't fully understand how this is breaking the file reuse though? All this is doing is adding zero padding to the number
There was a problem hiding this comment.
It means I can't reuse files made in v2.3.9 (or earlier) when running workflows created with this patch in place.
There was a problem hiding this comment.
Okay, that's fair
We have a few tweaks that are needed for the v2.3 release branch. I'll track these here, not yet ready for merging.