Unpin lalsuite version #5040
Unpin lalsuite version #5040
Conversation
|
Don't you also need to change something here? https://github.com/gwastro/pycbc/blob/master/.github/workflows/basic-tests.yml#L31-L37 |
|
Huh, HDF5 errors and a segfault, interesting… |
I think they're the same error, and I think it originates with me not understanding git lfs ... Grumble, grumble, grumble ... Moving to a direct curl instead, I understand curl. |
|
But the segfault is indicative of a bigger problem, potentially an unchecked error condition in lalsimulation. |
That's probably right .... But I'm not sure I want to go down that rabbit hole. Jolien's HDF code did fail, so I suspect that SEOB carried on with a |
* Unpin lalsuite version * Do need to download new ROM files * Try this ... I hate git lfs, it sucks * Try this * What Tito says
* Avoid nan values in network volume term * Add a nan shield into the get_n_louder function when calculating significance * Add logging to nanmask in significance * Some fixes * Only do the copy/replacement lines if any valuies are actually nan - we are checking for the logs anyway now so move it here * Moving/altering another comment * TD suggestions * Use numpy where instead of copy/edit in place * tiny typo * Get #5051 into this PR * stat is numpy not np * Fix for isnan on an array * PyGRB: minor fixes to workflow generator (#5038) * Update jobsetup.py Minor bugfix related to single detector runs * Update pycbc_make_offline_grb_workflow Fixing the workflow generator for the case in which veto definer files are empty for a specific detector. * Update pycbc_make_offline_grb_workflow * Converting indexes of triggers into np.int32 because of numpy 2.x (#4961) * Converting indexes of triggers into np.int32 because of numpy 2.x * Minor changes only for comment lines --------- Co-authored-by: jacquot <jacquot@> * Unpin lalsuite version (#5040) * Unpin lalsuite version * Do need to download new ROM files * Try this ... I hate git lfs, it sucks * Try this * What Tito says * Fix CI failures (#5051) * Try finding source of error * Is it *just* this script? * Revert "Is it *just* this script?" This reverts commit 858cbf8. * Try avoiding mkl blas * Avoid failing sphinx * Revert lalsuite pin * Try to fix test_skymax on Numpy 2 (#4991) * Try to fix test_skymax on Numpy 2 * Make test less strict * Make it even less strict :( * Even *less* strict! * Get part of #4997 * typo --------- Co-authored-by: Thomas Dent <[email protected]> Co-authored-by: segomezlo <[email protected]> Co-authored-by: Thomas-JACQUOT <[email protected]> Co-authored-by: Ian Harry <[email protected]> Co-authored-by: Tito Dal Canton <[email protected]>
The various data files needed for lalsuite are now available publically again (lalsuite will inform the user of this if the user does not have the files in their path).
Therefore I unpin lalsuite. I've dumped the new SEOBNR file into our existing CVMFS directory so the CI will need no more changes.
To confirm SEOBNRv4_ROM_v3 is identical to SEOBNRv4_ROM_v2 (it just contains a certain bit of metadata that is irrelevant for us).
This would be needed for #5019 (and a lalsuite release that uses igwn-ligolw, if that doesn't already exist).