1.1.0, streaming response body support #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
curl.request
returns a stream to you (the call does not throw an exception), then you must callclose
on the stream when you are done.Calling
close
is ok after a stream has been fully read or at any time before that to end a stream early.Calling
close
is a dealloc call so calling close multiple times is not ok.Calling
close
is necessary because the internal Curly thread handling the requests with libcurl has no way of knowing when you don't care about the request anymore.The meaning of
timeout
is as follows: the stream must open (all headers received) within that number of seconds. After the headers have been received,curl.request
returns a stream. Some number of bytes must arrive within thetimeout
seconds interval since the lastread
, or the stream will raise an exception fromread
as a timeout.