Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs() accessor to the PlatformEval type. #423

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

anforowicz
Copy link
Contributor

This helps guppy clients which don't want to eval the condition, and instead want to decompose and analyze the condition. An example of one such client can be found in:

This helps `guppy` clients which don't want to `eval` the condition,
and instead want to decompose and analyze the condition.  An example
of one such client can be found in:

* https://crrev.com/c/6259145/9/tools/crates/gnrt/lib/deps.rs#406
* https://crrev.com/c/6259145/9/tools/crates/gnrt/lib/gn.rs#513
@sunshowers
Copy link
Member

Looks fantastic, thank you!

@sunshowers sunshowers merged commit a0ad2c4 into guppy-rs:main Feb 21, 2025
18 checks passed
@sunshowers
Copy link
Member

Changed the name to target_specs, returned the underlying slice, and released it as guppy 0.17.17 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants