Fix JSON format bug and duplicate test clean-up #2418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunthercox
requested changes
Jul 1, 2025
| from django.test import TestCase | ||
| from django.urls import reverse | ||
|
|
||
|
|
There was a problem hiding this comment.
Two blank lines before a top level function is preferred to adhere to pep8:
| def test_post(self): | ||
| """ | ||
| Test that a response is returned. | ||
| """ |
There was a problem hiding this comment.
Could the docstrings in these functions have been improved instead of removed?
| response = self.client.post( | ||
| self.api_url, | ||
| data=json.dumps({ | ||
| 'text': u'سلام' |
There was a problem hiding this comment.
I had to look this one up, but this seems safe to remove ✅
(Python 3 no longer needs the u bytemark, good to know)
|
|
||
| def test_delete(self): | ||
| response = self.client.delete(self.api_url) | ||
|
|
There was a problem hiding this comment.
A space between test calls and assertions is preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a small bug and improves the structure of the test cases.
Fixed:
jsonmodule as a format parameterClean-up:
Let me know if anything else is needed. Happy to help!