Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Shape.split to support arbitrary splitting surfaces #427

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MatthiasJ1
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3a5a4e5) 96.04% compared to head (eee38b7) 96.02%.

Files Patch % Lines
src/build123d/topology.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #427      +/-   ##
==========================================
- Coverage   96.04%   96.02%   -0.03%     
==========================================
  Files          24       24              
  Lines        7413     7422       +9     
==========================================
+ Hits         7120     7127       +7     
- Misses        293      295       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Dec 9, 2023

I've added comments to the code. In general, all code must pass pylint (missing docstrings here) and have good test coverage.

@MatthiasJ1
Copy link
Contributor Author

Interior point selection can be made significantly more robust but depends on support for either Plane-Face or Face-Face intersection (#328)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants