Skip to content

Streamline topology exploration #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

jdegenstein
Copy link
Collaborator

This is an updated version of PR #873 (see discussion there for more context)

The goal of this PR is to streamline topology exploration across the entire codebase. Currently, there are topology exploration methods scattered in several places. The new method is apparently more repeatable in the way it explores topology.

This PR is still very rough as I am still deciding if it is possible to have a single return format that works for all applications, or to keep a few methods (all of which should exist in one central place like shape_core.py).

@jdegenstein jdegenstein marked this pull request as draft July 16, 2025 17:13
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.54%. Comparing base (551cd3b) to head (b311d73).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/build123d/topology/shape_core.py 75.00% 6 Missing ⚠️
src/build123d/exporters3d.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1036      +/-   ##
==========================================
- Coverage   96.63%   96.54%   -0.10%     
==========================================
  Files          32       32              
  Lines       10157    10151       -6     
==========================================
- Hits         9815     9800      -15     
- Misses        342      351       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant