Fix building on Windows with MSYS2 #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply GCC `#pragma`s to Clang too, and also more to fix the things Clang catches that GCC doesn't
It's already being done for Cygwin, presumably for the same reasons. Clang auto-applies `-mbig-obj` as needed it seems: https://reviews.llvm.org/D102419 Tests against `std::filesystem` remain broken, though, and building with MinGW still requires disabling them manually with `-DGHC_FILESYSTEM_BUILD_STD_TESTING=NO`: gulrak#189 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
-mbig-objtoCXXFLAGSby default for MinGW in general, instead of just Cygwin)#ifdefss around the GCC#pragmas to also work for Clang, and adds more to fix the things Clang catches that GCC doesn't)Tests against
std::filesystemremain broken, and must be disabled using-DGHC_FILESYSTEM_BUILD_STD_TEST=NO, but at least-DCMAKE_CXX_FLAGS=-Wa,-mbig-objis no longer required to be passed explicitly.If any of the above are undesirable, it can be reverted and/or added in a separate PR.
Fixes #189