Remove tracer bits for now

README.md

@@ -2,6 +2,7 @@ Native Go Zookeeper Client Library
 ===================================
 
 [![Build Status](https://travis-ci.org/samuel/go-zookeeper.png)](https://travis-ci.org/samuel/go-zookeeper)
+[![Coverage Status](https://coveralls.io/repos/github/samuel/go-zookeeper/badge.svg?branch=master)](https://coveralls.io/github/samuel/go-zookeeper?branch=master)
 
 Documentation: http://godoc.org/github.com/samuel/go-zookeeper/zk
 

zk/dnshostprovider.go

@@ -59,6 +59,7 @@ func (hp *DNSHostProvider) Init(servers []string) error {
 	return nil
 }
 
+// Len returns the number of servers available
 func (hp *DNSHostProvider) Len() int {
 	hp.mu.Lock()
 	defer hp.mu.Unlock()
@@ -79,7 +80,7 @@ func (hp *DNSHostProvider) Next() (server string, retryStart bool) {
 	return hp.servers[hp.curr], retryStart
 }
 
-// Notify the HostProvider of a successful connection.
+// Connected notifies the HostProvider of a successful connection.
 func (hp *DNSHostProvider) Connected() {
 	hp.mu.Lock()
 	defer hp.mu.Unlock()

zk/structs.go

@@ -598,43 +598,3 @@ func requestStructForOp(op int32) interface{} {
 	}
 	return nil
 }
-
-func responseStructForOp(op int32) interface{} {
-	switch op {
-	case opClose:
-		return &closeResponse{}
-	case opCreate:
-		return &createResponse{}
-	case opDelete:
-		return &deleteResponse{}
-	case opExists:
-		return &existsResponse{}
-	case opGetAcl:
-		return &getAclResponse{}
-	case opGetChildren:
-		return &getChildrenResponse{}
-	case opGetChildren2:
-		return &getChildren2Response{}
-	case opGetData:
-		return &getDataResponse{}
-	case opPing:
-		return &pingResponse{}
-	case opSetAcl:
-		return &setAclResponse{}
-	case opSetData:
-		return &setDataResponse{}
-	case opSetWatches:
-		return &setWatchesResponse{}
-	case opSync:
-		return &syncResponse{}
-	case opWatcherEvent:
-		return &watcherEvent{}
-	case opSetAuth:
-		return &setAuthResponse{}
-	// case opCheck:
-	// 	return &checkVersionResponse{}
-	case opMulti:
-		return &multiResponse{}
-	}
-	return nil
-}

zk/structs_test.go

@@ -18,6 +18,16 @@ func TestEncodeDecodePacket(t *testing.T) {
 	encodeDecodeTest(t, &multiRequest{Ops: []multiRequestOp{{multiHeader{opCheck, false, -1}, &CheckVersionRequest{"/", -1}}}})
 }
 
+func TestRequestStructForOp(t *testing.T) {
+	for op, name := range opNames {
+		if op != opNotify && op != opWatcherEvent {
+			if s := requestStructForOp(op); s == nil {
+				t.Errorf("No struct for op %s", name)
+			}
+		}
+	}
+}
+
 func encodeDecodeTest(t *testing.T, r interface{}) {
 	buf := make([]byte, 1024)
 	n, err := encodePacket(buf, r)