Skip to content

Fixes #4053. v2 WindowsDriver and v2win doesn't show any scenario in the UICatalog with cmd or conhost #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: v2_develop
Choose a base branch
from

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Apr 25, 2025

Fixes

Proposed Changes/Todos

  • Fixes WindowsDriver
  • Fixes v2win, but still doesn't work using VS2022 debugger and doesn't resize well when the size was changed on another scenario and returning to the main app.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner April 25, 2025 22:12
@BDisp BDisp marked this pull request as draft April 25, 2025 22:13
@BDisp BDisp marked this pull request as ready for review April 26, 2025 14:58
@BDisp
Copy link
Collaborator Author

BDisp commented Apr 26, 2025

This is ready for review. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 WindowsDriver and v2win doesn't show any scenario in the UICatalog with cmd or conhost
1 participant