Add None checking in refresh sensors #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtdiehl any reason this can't be merged? |
|
@gtdiehl pretty please!? |
|
The root cause of this is just that the default timeout is sometimes too short for the IoTaWatt. Perhaps that would be a more useful error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should help with the issue reported here #6. I have seen similar issues on my homeassistant install as well.
'NoneType' object has no attribute 'text'
Traceback (most recent call last):
File "/srv/homeassistant/lib64/python3.9/site-packages/homeassistant/helpers/update_coordinator.py", line 187, in _async_refresh
self.data = await self._async_update_data()
File "/srv/homeassistant/lib64/python3.9/site-packages/homeassistant/components/iotawatt/coordinator.py", line 65, in _async_update_data
await self.api.update(lastUpdate=self._last_run)
File "/srv/homeassistant/lib64/python3.9/site-packages/iotawattpy/iotawatt.py", line 76, in update
await self._refreshSensors(timespan, lastUpdate)
File "/srv/homeassistant/lib64/python3.9/site-packages/iotawattpy/iotawatt.py", line 154, in _refreshSensors
results = response.text
AttributeError: 'NoneType' object has no attribute 'text'