WIP EXPERIMENTAL: File access in javascript #2280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if we want to merge this at all. Putting it here to drive discussion. |
|
We should not expose file management features to the web/webview, risky to get misused. Some things might be interesting but it needs to be very very careful if it needs to be. |
harshad1
commented
May 21, 2024
| @@ -62,4 +79,20 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| @Override | |||
| public void onPageStarted(final WebView view, final String url, final Bitmap favicon) { | |||
There was a problem hiding this comment.
For some added safety I added this to disable file access for non-local files.
Most of this PR is to be looked at as an experiment, not to merged anytime soon :)
|
Closing this PR. I want to explore other avenues for enabling more functionality from JS |
|
As usual idea and improvements are welcome. Only need to make sure it not creates high exploitable threats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am experimenting with adding a 'Markor' api to javascript opened in the webview.
This API will allow reading / writing / navigating the file system from javascript in a webview.
May enable useful extensions to markor by users.