Add app-wide themes #2258
Draft
Add app-wide themes #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
April 3, 2024 11:12
gsantner
requested changes
Apr 20, 2024
| setTheme(R.style.AppTheme_Unified); | ||
| } | ||
|
|
||
| if (_appSettings.getAppAccentName().contains("black_white")) { |
There was a problem hiding this comment.
When it's done this way, next time people will complain that they can't customize colors. While it's more possibilities, it's still limited to a small amount of hardcoded colors this way.
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| name: "CI" | |||
|
|
|||
| on: [push, pull_request] | |||
| on: [push, pull_request, workflow_dispatch, workflow_call] | |||
There was a problem hiding this comment.
please revert changes to the workflow files. You can of course keep whatever personal you do....in your own branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore my commit for workflow part. I was trying to get my workflow to work and publish apk to my repo.
This is start of theme system / chooser for markor.
I know I need to add more themes to match to the ones in the notepad part.
I think people should be able to change accents / icons colors and other colors esp on the main app.