WIP: Fixes #2182 with a more compact display of file browser items: #2205
Conversation
halfdane
commented
Jan 12, 2024
halfdane
commented
- Introduces a preference to enable "compact view" of file browser items
- if preference is enabled, filename an description are layed out horizontally instead of vertically
- Introduces a preference to enable "compact view" of file browser items - if preference is enabled, filename an description are layed out horizontally instead of vertically
|
Could you add a before and after screenshot here? |
| <Space | ||
| android:layout_width="8dp" | ||
| android:layout_height="wrap_content" /> |
There was a problem hiding this comment.
Makes default vertical layout 8dp bigger by adding this spacer. If it's really needed for horiziontal, hide it in vertical please.
Generally I'm not a fan to add a own settings option just so everyone can disable every tiny bit they personally dislike. This is bloat.
There was a problem hiding this comment.
To add to this.
IMO if we can come up with a slightly more compact clean layout which doesn't compromise anything we should just switch to that as the new default.
|
Sorry to say, but I don't want to merge/implement this. I know some people would like every tiny bit finetuned to their personal taste, but I want to add to-my-feeling unnecessary things. There is a certain size that works fine for fingers/thumbs (""minimum viable button touch width/height""). The current size seems quite fitting, it shouldn't decrease too much then it's currently. If you find additional ways to improve it, feel free to. But it should be a general improvement that fits without a settings option (and not slams everything into one line). Like adjusting margins or so. |
gsantner
changed the title
