Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(timezone): add timezone to schedules #186

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mforesti
Copy link
Collaborator

@mforesti mforesti commented Feb 12, 2025

Summary

In this PR, the timezone is added to the schedules.

Impact

  • App
  • Supabase functions
  • Supabase migration
  • CI / GitHub
  • pubspec.yaml

Testing steps

  • Add a new schedule with a different timezone than the one of the device.
  • Check wether the time shown in the schedule instances aligns with you timezone.
  • Add replies and default rules. The buttons must behave correctly

Open points

  • Add search capability to the timezone list in the schedule form.
  • Show to the user the timezone of the event and the time at the remote location when the timezone differs from the local one.
  • Add test case to cover timezone

Comment on lines +97 to +102
} else if (snapshot.hasError) {
return Text('Error: ${snapshot.error}');
} else if (!snapshot.hasData ||
snapshot.data!.isEmpty) {
return Text('No data');
} else {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if (snapshot.hasError) {
return Text('Error: ${snapshot.error}');
} else if (!snapshot.hasData ||
snapshot.data!.isEmpty) {
return Text('No data');
} else {
} else if (snapshot.hasError ||
!snapshot.hasData ||
snapshot.data!.isEmpty) {
return Text('--:--');
} else {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a bit more user-friendly.

@mforesti mforesti force-pushed the refactor/timezone branch from 4831e23 to f106345 Compare March 11, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant