Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify action #1172

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat: simplify action #1172

merged 2 commits into from
Aug 5, 2024

Conversation

manumbs
Copy link
Member

@manumbs manumbs commented Jul 29, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Simplify usage of action: grupoboticario/actions-setup-sap-rfc

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@manumbs manumbs requested a review from alvarolimajr July 29, 2024 18:41
@manumbs manumbs self-assigned this Jul 29, 2024
@manumbs manumbs force-pushed the feature/simplify-action branch 14 times, most recently from 696b6bc to 26ae5c4 Compare July 29, 2024 20:19
@manumbs manumbs force-pushed the feature/simplify-action branch from 26ae5c4 to e3a740c Compare July 29, 2024 20:23
Copy link
Contributor

@alvarolimajr alvarolimajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manumbs muito obrigado pela colaboração, mandou muito bem!!! Parabéns!
Deixei somente alguns comentários sobre a secret ser GH_TOKEN e alguns momentos estar como GITHUB_TOKEN.

Copy link
Contributor

@alvarolimajr alvarolimajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manumbs Aprovado!

@alvarolimajr alvarolimajr merged commit 6921dcb into main Aug 5, 2024
2 checks passed
@alvarolimajr alvarolimajr deleted the feature/simplify-action branch August 5, 2024 18:56
github-actions bot pushed a commit that referenced this pull request Aug 9, 2024
## [4.1.0](v4.0.5...v4.1.0) (2024-08-09)

### Features

* simplify action ([#1172](#1172)) ([6921dcb](6921dcb))

### Chores

* bump versions ([7b69c84](7b69c84))
* bump versions ([6a4260a](6a4260a))
* bump versions ([06ba9cf](06ba9cf))
* fixing conventional-changelog-conventionalcommits ([fb8e243](fb8e243))
Copy link

github-actions bot commented Aug 9, 2024

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants