Terratest build fixes #1395
Open
Terratest build fixes #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into deps-update
yhakbar
reviewed
May 23, 2024
| @@ -24,7 +24,7 @@ func TestGetRecommendedRdsInstanceTypeHappyPath(t *testing.T) { | |||
| databaseEngine: "mysql", | |||
| engineMajorVersion: "8.0", | |||
| instanceTypes: []string{"db.t2.micro", "db.t3.micro", "db.t3.small"}, | |||
| expected: "db.t2.micro", | |||
| expected: "db.t3.micro", | |||
There was a problem hiding this comment.
NIT: Consider jumping straight to db.t4g.micro, so you can delay dealing with this again for a while.
yhakbar
reviewed
May 23, 2024
There was a problem hiding this comment.
Did you mean to commit this file? It should be ignored. Please force push the removal of the file so that it's cleaned out of history if not intentional.
There was a problem hiding this comment.
It is by intention, to deploy on new lambda runtime, executable should be named bootstrap
In the project directory that contains your application's main.go file, compile your executable. Note the following:
The executable must be named bootstrap. For more information, see Naming.
https://docs.aws.amazon.com/lambda/latest/dg/golang-package.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included changes:
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Added support for Packer 1.10
Fixed Helm and Packer tests
Migration Guide