-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add test fixtures for incorrect relative source in stacks #4080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis update introduces a new unit configuration for "app1." A configuration block is added in the stack file to declare the unit with a source set to Changes
Sequence Diagram(s)sequenceDiagram
participant StackConfig as Stack Config
participant TGEngine as Terragrunt Engine
participant UnitConfig as Unit Config
StackConfig->>TGEngine: Load terragrunt.stack.hcl (unit "app1")
TGEngine->>UnitConfig: Access terragrunt.hcl in unit "app1" directory
UnitConfig-->>TGEngine: Return configuration (terraform { source = "." })
Suggested reviewers
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/fixtures/stacks/errors/relative-source-incorrect/live/terragrunt.stack.hcl (1)
2-5
: Intentional Misconfiguration for Testing Purposes.
The unit"app1"
is declared with a source set to"../../units/app1"
, and a comment indicates that the intended correct source is"../units/app1"
. This appears to be an intentional misconfiguration designed as a test fixture to simulate and validate error handling for incorrect relative source paths. Please confirm that the accompanying tests and documentation explicitly reference this intentional misconfiguration.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
test/fixtures/stacks/errors/relative-source-incorrect/live/terragrunt.stack.hcl
(1 hunks)test/fixtures/stacks/errors/relative-source-incorrect/units/app1/terragrunt.hcl
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: unessential
- GitHub Check: build-and-test
🔇 Additional comments (1)
test/fixtures/stacks/errors/relative-source-incorrect/units/app1/terragrunt.hcl (1)
1-3
: Approval: Terragrunt Module Source Configuration is Correct.
The configuration block properly sets the Terraform module source to"."
, which is the expected reference for a unit configuration.
Fixed in #4078 |
Description
The error for wrong relative source input to a stack is misleading.

Consider messaging like 👇
Summary by CodeRabbit