Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration options for AWS S3 server access logging #3004

Conversation

findmyname666
Copy link

@findmyname666 findmyname666 commented Mar 15, 2024

Description

Fixes #3003.

In our environment the S3 bucket where should be stored S3 access logs is pre-created by "central" team and we don't have permissions to do any changes. In such case we don't have to:

  • Create it - the current code creates the logging bucket only if it doesn't exist. No change is needed.
  • Configure logging bucket e.g. ACL, public access, encryption, tls enforcement - adding option to skip the configuration for access log bucket.
  • PartitionDateSource - Adding one more option to allow users to configure PartitionDateSource.

Additionally 1) adding error logging into the function configureAccessLogBucket. Without it I wasn't able to detect why the policy isn't configured. The error is returned but ignored. 2) Adding code to detect if the logging policy / configuration was change. The previous code just check if some policy is enabled.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

N/A.

@findmyname666 findmyname666 force-pushed the feature/s3-new-options-access-logging-2922 branch from bbc25d9 to bcf4226 Compare March 15, 2024 14:19
@findmyname666
Copy link
Author

I did typo in a branch name so I created a new PR #3006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose additional configuration options for AWS S3 server access logging
2 participants