Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose additional configuration options for AWS S3 server access logging #3003

Open
findmyname666 opened this issue Mar 15, 2024 · 0 comments · May be fixed by #3006
Open

Expose additional configuration options for AWS S3 server access logging #3003

findmyname666 opened this issue Mar 15, 2024 · 0 comments · May be fixed by #3006
Labels
enhancement New feature or request

Comments

@findmyname666
Copy link

Describe the solution you'd like

In our environment, the AWS S3 bucket where S3 access logs should be stored is pre-created by the "central" team, and we don't have permissions to make any changes to it. Therefore, we don't need to:

  • Create it: The current code creates the logging bucket only if it doesn't exist, which is already appropriate.
  • Change configuration of the logging bucket, such as ACL, public access, encryption, or TLS enforcement.

Currently, we cannot configure server access logging because we have to use the pre-created bucket. Additionally, it would be beneficial to have the option to configure PartitionDateSource in the logging configuration.
Example:

{
  "LoggingEnabled": {
    "TargetBucket": "<bucket_name> ",
    "TargetPrefix": "",
    "TargetObjectKeyFormat": {
      "PartitionedPrefix": {
        "PartitionDateSource": "EventTime"
      }
    }
  }
}

There is also a small bug because the current code silently fails on the permission error when attempting to configure the logging bucket.

Describe alternatives you've considered

The only alternative is to configure access logging outside of Terragrunt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant