-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GNU C++ demangler #1834
Open
nicolasnoble
wants to merge
7
commits into
grumpycoders:main
Choose a base branch
from
nicolasnoble:demangle
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,273
−9
Open
Adding GNU C++ demangler #1834
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d621e93
Adding PEGTL dependency.
nicolasnoble c7df155
First pass at the demangler.
nicolasnoble 1e1cc98
Building on Windows.
nicolasnoble 12443a5
Code fixes and reorganization, plus stubbing actions and adding dotpr…
nicolasnoble 58ca2e2
Starting to add some tests.
nicolasnoble 8bcd05d
Fixing compile_flags.txt
nicolasnoble bfd9f4a
Windows build fixes.
nicolasnoble File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,30 @@ | ||
| -std=c++2a | ||
| -std=c++2b | ||
| -fexceptions | ||
| -I. | ||
| -Isrc | ||
| -Ithird_party | ||
| -Ithird_party/ELFIO | ||
| -Ithird_party/fmt/include/ | ||
| -Ithird_party/gl3w | ||
| -Ithird_party/googletest/googletest/include | ||
| -Ithird_party/imgui | ||
| -Ithird_party/imgui/backends | ||
| -Ithird_party/imgui/examples | ||
| -Ithird_party/imgui/misc/cpp | ||
| -Ithird_party/http-parser | ||
| -Ithird_party/libelfin | ||
| -Ithird_party/luajit/src | ||
| -Ithird_party/luv/src | ||
| -Ithird_party/luv/deps/lua-compat-5.3/c-api | ||
| -Ithird_party/ucl | ||
| -Ithird_party/ucl/include | ||
| -Ithird_party/libuv/include | ||
| -Ithird_party/zlib | ||
| -Ithird_party/md4c/src | ||
| -Ithird_party/PEGTL/include | ||
| -Ithird_party/ucl -Ithird_party/ucl/include | ||
| -Ithird_party/uriparser/include | ||
| -Ithird_party/zep/extensions | ||
| -Ithird_party/zep/include | ||
| -Ithird_party/xbyak/xbyak | ||
| -DLUAJIT_ENABLE_LUA52COMPAT | ||
| -DIMGUI_IMPL_OPENGL_LOADER_GL3W | ||
| -DIMGUI_ENABLE_FREETYPE | ||
| -DLUAJIT_ENABLE_LUA52COMPAT | ||
| -DZEP_FEATURE_CPP_FILE_SYSTEM | ||
| -DNVG_NO_STB | ||
| -DPB_STATIC_API |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
|
|
||
| MIT License | ||
|
|
||
| Copyright (c) 2025 PCSX-Redux authors | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
|
|
||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <string> | ||
| #include <string_view> | ||
|
|
||
| namespace PCSX { | ||
|
|
||
| namespace GNUDemangler { | ||
|
|
||
| bool internalCheck(); | ||
| bool trace(std::string_view mangled); | ||
| void printDot(std::string_view mangled); | ||
| std::string demangle(std::string_view mangled); | ||
|
|
||
| } // namespace GNUDemangler | ||
|
|
||
| } // namespace PCSX | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /*************************************************************************** | ||
| * Copyright (C) 2025 PCSX-Redux authors * | ||
| * * | ||
| * This program is free software; you can redistribute it and/or modify * | ||
| * it under the terms of the GNU General Public License as published by * | ||
| * the Free Software Foundation; either version 2 of the License, or * | ||
| * (at your option) any later version. * | ||
| * * | ||
| * This program is distributed in the hope that it will be useful, * | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of * | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * | ||
| * GNU General Public License for more details. * | ||
| * * | ||
| * You should have received a copy of the GNU General Public License * | ||
| * along with this program; if not, write to the * | ||
| * Free Software Foundation, Inc., * | ||
| * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. * | ||
| ***************************************************************************/ | ||
|
|
||
| #include "gtest/gtest.h" | ||
| #include "support/gnu-c++-demangler.h" | ||
|
|
||
| TEST(GNUDemangler, _Z1fv) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z1fv"), "f(void)"); } | ||
| TEST(GNUDemangler, _Z1fi) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z1fi"), "f(int)"); } | ||
| TEST(GNUDemangler, _Z3foo3bar) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z3foo3bar"), "foo(bar)"); } | ||
| TEST(GNUDemangler, _Zrm1XS_) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Zrm1XS_"), "operator%(X, X)"); } | ||
| TEST(GNUDemangler, _ZplR1XS0_) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZplR1XS0_"), "operator+(X&, X&)"); } | ||
| TEST(GNUDemangler, _ZlsRK1XS1_) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZlsRK1XS1_"), "operator<< (X const&, X const&)"); | ||
| } | ||
| TEST(GNUDemangler, _ZN3FooIA4_iE3barE) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN3FooIA4_iE3barE"), "Foo<int[4]>::bar"); | ||
| } | ||
| TEST(GNUDemangler, _Z1fIiEvi) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z1fIiEvi"), "void f<int>(int)"); } | ||
| TEST(GNUDemangler, _Z5firstI3DuoEvS0_) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z5firstI3DuoEvS0_"), "void first<Duo>(Duo)"); | ||
| } | ||
| TEST(GNUDemangler, _Z5firstI3DuoEvT_) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z5firstI3DuoEvT_"), "void first<Duo>(Duo)"); | ||
| } | ||
| TEST(GNUDemangler, _Z3fooIiPFidEiEvv) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z3fooIiPFidEiEvv"), "void foo<int,int(*)(double),int>()"); | ||
| } | ||
| TEST(GNUDemangler, _ZN1N1fE) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN1N1fE"), "N::f"); } | ||
| TEST(GNUDemangler, _ZN6System5Sound4beepEv) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN6System5Sound4beepEv"), "System::Sound::beep()"); | ||
| } | ||
| TEST(GNUDemangler, _ZN5Arena5levelE) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN5Arena5levelE"), "Arena::level"); } | ||
| TEST(GNUDemangler, _ZN5StackIiiE5levelE) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN5StackIiiE5levelE"), "Stack<int, int>::level"); | ||
| } | ||
| TEST(GNUDemangler, _Z1fI1XEvPVN1AIT_E1TE) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z1fI1XEvPVN1AIT_E1TE"), "void f<X>(A<X>::T volatile*)"); | ||
| } | ||
| TEST(GNUDemangler, _ZngILi42EEvN1AIXplT_Li2EEE1TE) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZngILi42EEvN1AIXplT_Li2EEE1TE"), "void operator-<42>(A<(42)+(2)>::T)"); | ||
| } | ||
| TEST(GNUDemangler, _Z4makeI7FactoryiET_IT0_Ev) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z4makeI7FactoryiET_IT0_Ev"), "Factory<int> make<Factory, int>()"); | ||
| } | ||
| TEST(GNUDemangler, _Z3foo5Hello5WorldS0_S_) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z3foo5Hello5WorldS0_S_"), "foo(Hello, World, World, Hello)"); | ||
| } | ||
| TEST(GNUDemangler, _Z3fooPM2ABi) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_Z3fooPM2ABi"), "foo(int AB::**)"); } | ||
| TEST(GNUDemangler, _ZlsRSoRKSs) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZlsRSoRKSs"), "operator<<(std::ostream&,std::string const&)"); | ||
| } | ||
| TEST(GNUDemangler, _ZTI7a_class) { EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZTI7a_class"), "typeid(class a_class)"); } | ||
| TEST(GNUDemangler, _ZN4PCSX10SystemImplC2ERKNS_9ArgumentsE) { | ||
| EXPECT_EQ(PCSX::GNUDemangler::demangle("_ZN4PCSX10SystemImplC2ERKNS_9ArgumentsE"), | ||
| "PCSX::SystemImpl::SystemImpl(PCSX::Arguments const&)"); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the copyright year.
The copyright year is set to 2025, which is in the future. Please update it to the current year (2024).
📝 Committable suggestion