psyqo Multi-tap driver and example update #1815
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| multitap.cpp | 1 advisory rule | 10.00 → 9.61 | Suppress |
| advancedpad.cpp | 1 advisory rule | 7.22 → 7.20 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method advancedpad.cpp: psyqo::AdvancedPad::readPad
- Complex Method multitap.cpp: MultitapTestScene::printPadType
✅ Improving Code Health:
- Overall Code Complexity advancedpad.cpp
Annotations
Check warning on line 211 in src/mips/psyqo/examples/multitap/multitap.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
MultitapTestScene::printPadType has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 270 in src/mips/psyqo/src/advancedpad.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
psyqo::AdvancedPad::readPad increases in cyclomatic complexity from 28 to 29, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1 in src/mips/psyqo/src/advancedpad.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 8.13 to 7.44, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.