Breakpoint improvements

src/core/debug.h

@@ -35,6 +35,7 @@ class Debug {
     uint32_t normalizeAddress(uint32_t address);
     static inline std::function<const char*()> s_breakpoint_type_names[] = {l_("Exec"), l_("Read"), l_("Write")};
     enum class BreakpointType { Exec, Read, Write };
+    enum class BreakpointCondition { Always, Change, Greater, Less, Equal };
 
     void checkDMAread(unsigned c, uint32_t address, uint32_t len) {
         std::string cause = fmt::format("DMA channel {} read", c);
@@ -76,6 +77,10 @@ class Debug {
             : m_type(type), m_source(source), m_invoker(invoker), m_base(base), m_label(label) {}
         std::string name() const;
         BreakpointType type() const { return m_type; }
+        BreakpointCondition condition() const { return m_condition; }
+        void setCondition(BreakpointCondition condition) { m_condition = condition; }
+        uint32_t conditionData() const { return m_conditionData; }
+        void setConditionData(uint32_t data) { m_conditionData = data; }
         unsigned width() const { return getHigh() - getLow() + 1; }
         uint32_t address() const { return getLow(); }
         bool enabled() const { return m_enabled; }
@@ -93,6 +98,8 @@ class Debug {
         }
 
         const BreakpointType m_type;
+        BreakpointCondition m_condition = BreakpointCondition::Always;
+        uint32_t m_conditionData;
         const std::string m_source;
         const BreakpointInvoker m_invoker;
         mutable std::string m_label;
@@ -155,6 +162,7 @@ class Debug {
         if (m_lastBP == bp) m_lastBP = nullptr;
         delete const_cast<Breakpoint*>(bp);
     }
+    void removeAllBreakpoints() { m_breakpoints.clear(); }
 
   private:
     bool triggerBP(Breakpoint* bp, uint32_t address, unsigned width, const char* reason = "");

src/gui/widgets/assembly.cc

@@ -1,4 +1,4 @@
 /***************************************************************************
  *   Copyright (C) 2019 PCSX-Redux authors                                 *
  *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
@@ -340,6 +340,12 @@
             itemLabel = fmt::format(f_("Go to in Memory Editor #{}"), i + 1);
             if (ImGui::MenuItem(itemLabel.c_str())) jumpToMemory(addr, size, i, true);
         }
+        if (ImGui::MenuItem(_("Create Memory Read Breakpoint"))) {
+            g_emulator->m_debug->addBreakpoint(addr, Debug::BreakpointType::Read, size, _("GUI"));
+        }
+        if (ImGui::MenuItem(_("Create Memory Write Breakpoint"))) {
+            g_emulator->m_debug->addBreakpoint(addr, Debug::BreakpointType::Write, size, _("GUI"));
+        }
         ImGui::EndPopup();
     }
 }