Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue that only showed up on HW and now in emulators. Turns out it was caused by unsafe write before
dpct
.https://github.com/user-attachments/assets/aec0b48b-a2d5-4cce-ae55-ec48a3939f64
(the flickering vertex colors when doing interpolation)
Also added some safeguards against bad psyqo::Color being passed into the primitives when it can potentially affect the command (e.g. in setColor/setColorA).
E.g. consider this case:
Or you could possibly read the color from some RGB register and if it has the MSB set... you'd get tons of corruptions and crashes on HW. To prevent that, we need to mask away those potentially "dirty" bits in everything.