Patch System fixes/improvements #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rocketz
commented
Nov 16, 2024
rocketz
commented
- Fixed crash when deleting patches from Assembly view
- Added "are you sure?" popup when clicking "delete all"
- Added "are you sure?" popup when clicking "delete all"
nicolasnoble
approved these changes
Nov 17, 2024
| @@ -48,7 +48,7 @@ class PatchManager { | |||
| Patch& getPatch(int index) { return m_patches[index]; } | |||
|
|
|||
| int registerPatch(uint32_t address, Patch::Type type); | |||
| PatchManager::Patch::Type findPatch(uint32_t address) const; | |||
| int findPatch(uint32_t address) const; | |||
There was a problem hiding this comment.
It might be a bit cleaner to use std::optional<unsigned> for this, but that'll do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.