[Chores] Regen i18n #1708
[Chores] Regen i18n #1708
Conversation
nicolasnoble
force-pushed
the
chores-i18n
branch
6 times, most recently
from
81eb238 to
2de951f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
=======================================
Coverage 9.20% 9.20%
=======================================
Files 467 467
Lines 143962 143962
=======================================
Hits 13250 13250
Misses 130712 130712 ☔ View full report in Codecov by Sentry. |
nicolasnoble
force-pushed
the
chores-i18n
branch
15 times, most recently
from
11f7d40 to
5385772
Compare
nicolasnoble
force-pushed
the
chores-i18n
branch
7 times, most recently
from
0bfa935 to
82a9524
Compare
nicolasnoble
force-pushed
the
chores-i18n
branch
from
82a9524 to
6d4b944
Compare
nicolasnoble
force-pushed
the
chores-i18n
branch
2 times, most recently
from
00d87c5 to
af8d524
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments.
Actionable comments posted: 2
🔭 Outside diff range comments (2)
i18n/pcsx-redux.pot (2)
Missing translations and inconsistent technical terms found
- French (fr.po) and Greek (el.po) translations are missing for both unaligned address messages
- Some translations use simplified terms (LW/SW) instead of the technical terms (LWC2/SWC2)
🔗 Analysis chain
Line range hint
407-416: New translations needed for unaligned address messagesThe following new message strings have been added for unaligned address errors and require translations in all language files:
- "Unaligned address 0x%08x in LWC2 from 0x%08x\n"
- "Unaligned address 0x%08x in SWC2 from 0x%08x\n"
Let's verify if these strings are properly translated in the language files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if unaligned address strings are translated in language files rg -A 1 "msgid \"Unaligned address 0x%08x in LWC2 from 0x%08x\\\\n\"" i18n/*.po rg -A 1 "msgid \"Unaligned address 0x%08x in SWC2 from 0x%08x\\\\n\"" i18n/*.poLength of output: 1741
Translation issues found in patch management strings
- Most new strings are untranslated in all language files (el, es_ES, fr, pt_BR, uk, zh_CN)
- Existing translations for "Delete" and "Delete All" are incorrect as they're reused from save state context
- For example: "自动保存" (auto-save) in Chinese instead of "删除" (delete)
- Similar issues in Ukrainian, Portuguese, and Spanish translations
🔗 Analysis chain
Line range hint
3241-3285: New translations needed for patch management messagesThe following new message strings have been added for patch management functionality and require translations in all language files:
- "Patching is only available in Interpreted CPU mode"
- "Delete Patch?"
- "Delete"
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
Let's verify if these strings are properly translated in the language files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if patch management strings are translated in language files rg -A 1 "msgid \"Patching is only available in Interpreted CPU mode\"" i18n/*.po rg -A 1 "msgid \"Delete Patch\?"" i18n/*.po rg -A 1 "msgid \"NOP\"" i18n/*.po rg -A 1 "msgid \"Activate All\"" i18n/*.poLength of output: 841
Script:
#!/bin/bash # Description: Check remaining patch management strings with proper escaping rg -A 1 'msgid "Delete"' i18n/*.po rg -A 1 'msgid "NOP"' i18n/*.po rg -A 1 'msgid "Return"' i18n/*.po rg -A 1 'msgid "Activate All"' i18n/*.po rg -A 1 'msgid "Deactivate All"' i18n/*.po rg -A 1 'msgid "Delete All"' i18n/*.poLength of output: 2704
🛑 Comments failed to post (2)
i18n/fr.po (2)
3241-3285: 🛠️ Refactor suggestion
French translations needed for patch management
The new patch management messages are missing French translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Le patching n'est disponible qu'en mode CPU interprété" msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le patch ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les patches ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer##patches"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.msgid "Delete save" msgstr "" #: src/gui/widgets/patches.cc:35 msgid "Patching is only available in Interpreted CPU mode" msgstr "Le patching n'est disponible qu'en mode CPU interprété" #: src/gui/widgets/patches.cc:68 msgid "Delete Patch?" msgstr "Supprimer le patch ?" #: src/gui/widgets/patches.cc:69 msgid "Delete" msgstr "Supprimer" #: src/gui/widgets/patches.cc:88 msgid "NOP" msgstr "NOP" #: src/gui/widgets/patches.cc:88 msgid "Return" msgstr "Retour" #: src/gui/widgets/patches.cc:96 msgid "Activate All" msgstr "Tout activer" #: src/gui/widgets/patches.cc:101 msgid "Deactivate All" msgstr "Tout désactiver" #: src/gui/widgets/patches.cc:107 msgid "Delete All" msgstr "Tout supprimer" #: src/gui/widgets/patches.cc:111 msgid "Delete all Patches?" msgstr "Supprimer tous les patches ?" #: src/gui/widgets/patches.cc:112 msgid "Delete##patches" msgstr "Supprimer##patches" #: src/gui/widgets/pio-cart.cc:36 msgid "ROM"
407-416: 🛠️ Refactor suggestion
French translations needed for unaligned address messages
The unaligned address messages are missing French translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.#, c-format msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" #: src/core/gte.h:69 #, c-format msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n" #: src/core/memorycard.cc:348
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
i18n/pcsx-redux.pot (1)
Line range hint
3127-3166: Add missing translations for patch management messagesSeveral new messages related to patch management lack translations:
msgid "Patching is only available in Interpreted CPU mode" msgstr "" msgid "Delete Patch?" msgstr "" msgid "Delete" msgstr "" msgid "NOP" msgstr "" msgid "Return" msgstr "" msgid "Activate All" msgstr "" msgid "Deactivate All" msgstr "" msgid "Delete All" msgstr "" msgid "Delete all Patches?" msgstr "" msgid "Delete##patches" msgstr ""These UI messages should be translated in all localization files to maintain consistency.
🧹 Nitpick comments (5)
i18n/fr.po (5)
167-176: Missing translations for kernel checker read/write messages.Two kernel checker messages are missing translations:
- "Kernel checker: Reading %08x from %08x\n"
- "Kernel checker: Writing to %08x from %08x\n"
Would you like me to help generate translations for these messages to maintain consistency with other kernel-related strings?
406-415: Missing translations for unaligned address messages.Two messages about unaligned addresses in LWC2/SWC2 operations are missing translations:
- "Unaligned address 0x%08x in LWC2 from 0x%08x\n"
- "Unaligned address 0x%08x in SWC2 from 0x%08x\n"
Would you like me to help generate translations for these messages to maintain consistency with other unaligned address messages in the codebase?
924-931: Missing translations for texture-related settings.Two GPU configuration options are missing translations:
- "Disable textures for polygons"
- "Disable textures for sprites"
Would you like me to help generate translations for these texture-related settings?
2319-2330: Missing translations for patch-related actions.Several patch-related messages are missing translations:
- "Delete Return Patch"
- "Delete NOP Patch"
Would you like me to help generate translations for these patch management actions to maintain consistency with other similar strings?
3244-3283: Missing translations for patch functionality messages.Multiple patch-related messages are missing translations:
- "Patching is only available in Interpreted CPU mode"
- "Delete Patch?"
- "Delete"
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
Would you like me to help generate translations for these patch-related messages to ensure a complete French localization of the patching functionality?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(24 hunks)i18n/fr.po(22 hunks)i18n/pcsx-redux.pot(22 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pt_BR.po
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: Analyze the repo with CodeSee
🔇 Additional comments (5)
i18n/el.po (2)
1235-1239: Fix fuzzy translation for Show PatchesThe translation for "Show Patches" is marked as fuzzy and incorrectly reuses the translation for "Show Registers".
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"
400-411: Add Greek translations for unaligned address messagesThe new messages for unaligned LWC2/SWC2 address errors are untranslated.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"i18n/zh_CN.po (2)
407-416: Fix Chinese translations for unaligned address messagesThe new messages for unaligned LWC2/SWC2 address errors are marked as fuzzy and incorrectly reuse translations from LW/SW errors.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"
3241-3285: Fix Chinese translations for patch management messagesSeveral new messages related to patch management either lack translations or are marked as fuzzy with incorrect translations.
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"i18n/fr.po (1)
138-142: Missing translation for kernel checker message.The message "Kernel checker: Jump from 0x%08x to 0x%08x\n" is missing its French translation.
Let me check if there are similar kernel checker messages that could serve as a reference:
Would you like me to help generate a translation for this message and similar kernel-related strings?
| msgid "Open Disk Image" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/gui.cc:123 | ||
| msgid "Open Binary" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/gui.cc:124 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add missing translations for texture disable messages
New messages for disabling textures lack translations:
msgid "Disable textures for polygons"
msgstr ""
msgid "Disable textures for sprites"
msgstr ""These UI messages should be translated in all localization files to maintain consistency.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| msgid "Open Disk Image" | |
| msgstr "" | |
| #: src/gui/gui.cc:123 | |
| msgid "Open Binary" | |
| msgstr "" | |
| #: src/gui/gui.cc:124 | |
| msgid "Open Disk Image" | |
| msgstr "" | |
| #: src/gui/gui.cc:123 | |
| msgid "Open Binary" | |
| msgstr "" | |
| #: src/gui/gui.cc:124 | |
| msgid "Disable textures for polygons" | |
| msgstr "" | |
| msgid "Disable textures for sprites" | |
| msgstr "" |
nicolasnoble
force-pushed
the
chores-i18n
branch
from
af8d524 to
e7f5b01
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
i18n/fr.po (2)
Line range hint
34-415: Multiple UI strings need translationSeveral important UI strings related to GPU configuration and logging are not translated to French, including:
- "Fill polygons"
- "Wireframe"
- "Vertices only"
- "Polygon rendering mode"
- "No MSAA"
- "MSAA"
- "Use linear filtering"
And many more...This will impact French users' ability to navigate and use these features effectively.
Line range hint
1534-1559: Inconsistent translation pattern for "Enable" stringsThe translations for strings starting with "Enable" are inconsistent:
- "Enable Auto Update" → "Activer la mise à jour automatique"
- "Enable Debugger" → "Activer le débogueur"
But some are translated differently or missing translation.Maintain consistency by using the "Activer" pattern throughout the file.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pt_BR.po
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cross-arm64
🔇 Additional comments (9)
i18n/el.po (2)
1235-1239: 🛠️ Refactor suggestionFuzzy translation for Show Patches
The translation for "Show Patches" is marked as fuzzy and currently reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
400-409: 🛠️ Refactor suggestionGreek translations needed for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors are currently untranslated (empty msgstr). These should be translated to Greek to maintain consistency in the localization.
Add Greek translations for:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"Likely invalid or redundant comment.
i18n/zh_CN.po (1)
3241-3285: 🛠️ Refactor suggestionMissing or fuzzy Chinese translations for patch management
Several new messages related to patch management either lack translations or are marked as fuzzy with incorrect translations:
- "Patching is only available in Interpreted CPU mode" - untranslated
- "Delete Patch?" - fuzzy, using "自动保存"
- "Delete" - fuzzy, using "自动保存"
- "NOP" - untranslated
- "Return" - untranslated
- "Activate All" - untranslated
- "Deactivate All" - untranslated
- "Delete All" - fuzzy, using "自动保存"
- "Delete all Patches?" - fuzzy, using "自动保存"
- "Delete##patches" - fuzzy, using "自动保存"
Add proper Chinese translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/fr.po (1)
1251-1254: Translation "Afficher les Registres" for "Show Patches" is incorrectThe current translation reuses "Show Registers" translation. Based on the translation pattern in the file, it should be "Afficher les correctifs" or "Afficher les patches".
i18n/pcsx-redux.pot (5)
31-36: LGTM! CD-ROM messages are properly formatted.The format specifiers for track information and CD image loading are correctly defined.
128-188: LGTM! Debug messages are properly formatted.The format specifiers for hex addresses and debug information are correctly defined.
214-389: LGTM! GPU-related messages are properly formatted.The messages provide clear and consistent UI text for GPU configuration options.
393-401: Add missing translations for unaligned address messagesThe messages for unaligned LWC2/SWC2 address errors still lack translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" msgstr "" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" msgstr ""
903-910: Add missing translations for texture disable messagesThe messages for disabling textures still lack translations:
msgid "Disable textures for polygons" msgstr "" msgid "Disable textures for sprites" msgstr ""
| #: src/gui/gui.cc:1316 | ||
| msgid "Show Patches" | ||
| msgstr "" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add translation for patch management message
The new message for showing patches needs translation:
msgid "Show Patches"
msgstr ""
e7f5b01 to
e4bd452
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
i18n/pcsx-redux.pot (1)
903-910: New texture disable options need clear context for translators.These new UI strings for disabling textures should have translator comments to explain their usage context, as they are technical terms that may be challenging to translate accurately.
Add translator comments like:
+#. Checkbox option to disable texture mapping on 3D polygons msgid "Disable textures for polygons" msgstr "" +#. Checkbox option to disable texture mapping on 2D sprites msgid "Disable textures for sprites" msgstr ""
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🔇 Additional comments (4)
i18n/el.po (1)
1235-1239:⚠️ Potential issueFix fuzzy translation for "Show Patches"
The translation incorrectly reuses "Ένδειξη καταχωρητών" (Show Registers) for "Show Patches". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
i18n/zh_CN.po (1)
3241-3285:⚠️ Potential issueFix incorrect Chinese translations for patch management
Several strings are either missing translations or incorrectly marked as fuzzy with wrong translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/pcsx-redux.pot (1)
393-401: Format strings are consistent with error message patterns.The new unaligned address messages follow the established pattern for error messages, using consistent format specifiers (
0x%08x) for hex addresses.i18n/fr.po (1)
1250-1254:⚠️ Potential issueIncorrect translation reuse for "Show Patches".
The translation reuses "Afficher les Registres" (Show Registers) which is incorrect for this context.
Apply this fix:
msgid "Show Patches" -msgstr "Afficher les Registres" +msgstr "Afficher les correctifs"Likely invalid or redundant comment.
| #: src/gpu/soft/gpu.cc:261 | ||
| msgid "Disable textures for polygons" | ||
| msgstr "" | ||
|
|
||
| #: src/gpu/soft/gpu.cc:262 | ||
| msgid "Disable textures for sprites" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for texture disable options.
The new texture disable options lack French translations:
msgid "Disable textures for polygons"
-msgstr ""
+msgstr "Désactiver les textures pour les polygones"
msgid "Disable textures for sprites"
-msgstr ""
+msgstr "Désactiver les textures pour les sprites"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gpu/soft/gpu.cc:261 | |
| msgid "Disable textures for polygons" | |
| msgstr "" | |
| #: src/gpu/soft/gpu.cc:262 | |
| msgid "Disable textures for sprites" | |
| msgstr "" | |
| #: src/gpu/soft/gpu.cc:261 | |
| msgid "Disable textures for polygons" | |
| msgstr "Désactiver les textures pour les polygones" | |
| #: src/gpu/soft/gpu.cc:262 | |
| msgid "Disable textures for sprites" | |
| msgstr "Désactiver les textures pour les sprites" |
| #: src/gpu/soft/gpu.cc:261 | ||
| msgid "Disable textures for polygons" | ||
| msgstr "" | ||
|
|
||
| #: src/gpu/soft/gpu.cc:262 | ||
| msgid "Disable textures for sprites" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for texture disable options.
The new texture disable options lack Portuguese translations:
msgid "Disable textures for polygons"
-msgstr ""
+msgstr "Desativar texturas para polígonos"
msgid "Disable textures for sprites"
-msgstr ""
+msgstr "Desativar texturas para sprites"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gpu/soft/gpu.cc:261 | |
| msgid "Disable textures for polygons" | |
| msgstr "" | |
| #: src/gpu/soft/gpu.cc:262 | |
| msgid "Disable textures for sprites" | |
| msgstr "" | |
| #: src/gpu/soft/gpu.cc:261 | |
| msgid "Disable textures for polygons" | |
| msgstr "Desativar texturas para polígonos" | |
| #: src/gpu/soft/gpu.cc:262 | |
| msgid "Disable textures for sprites" | |
| msgstr "Desativar texturas para sprites" |
| #: src/gui/widgets/patches.cc:35 | ||
| msgid "Patching is only available in Interpreted CPU mode" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:68 | ||
| #, fuzzy | ||
| msgid "Delete Patch?" | ||
| msgstr "Auto-salvar" | ||
|
|
||
| #: src/gui/widgets/patches.cc:69 | ||
| #, fuzzy | ||
| msgid "Delete" | ||
| msgstr "Auto-salvar" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "NOP" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "Return" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:96 | ||
| msgid "Activate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:101 | ||
| msgid "Deactivate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:107 | ||
| #, fuzzy | ||
| msgid "Delete All" | ||
| msgstr "Auto-salvar" | ||
|
|
||
| #: src/gui/widgets/patches.cc:111 | ||
| #, fuzzy | ||
| msgid "Delete all Patches?" | ||
| msgstr "Auto-salvar" | ||
|
|
||
| #: src/gui/widgets/patches.cc:112 | ||
| #, fuzzy | ||
| msgid "Delete##patches" | ||
| msgstr "Auto-salvar" | ||
|
|
There was a problem hiding this comment.
Inconsistent translations for patch-related strings.
Several patch-related strings are either missing translations or incorrectly reusing "Auto-salvar":
Apply these fixes:
msgid "Patching is only available in Interpreted CPU mode"
-msgstr ""
+msgstr "O patch só está disponível no modo de CPU interpretada"
msgid "Delete Patch?"
-msgstr "Auto-salvar"
+msgstr "Excluir patch?"
msgid "Delete"
-msgstr "Auto-salvar"
+msgstr "Excluir"
msgid "Delete All"
-msgstr "Auto-salvar"
+msgstr "Excluir tudo"
msgid "Delete all Patches?"
-msgstr "Auto-salvar"
+msgstr "Excluir todos os patches?"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gui/widgets/patches.cc:35 | |
| msgid "Patching is only available in Interpreted CPU mode" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:68 | |
| #, fuzzy | |
| msgid "Delete Patch?" | |
| msgstr "Auto-salvar" | |
| #: src/gui/widgets/patches.cc:69 | |
| #, fuzzy | |
| msgid "Delete" | |
| msgstr "Auto-salvar" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "NOP" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "Return" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:96 | |
| msgid "Activate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:101 | |
| msgid "Deactivate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:107 | |
| #, fuzzy | |
| msgid "Delete All" | |
| msgstr "Auto-salvar" | |
| #: src/gui/widgets/patches.cc:111 | |
| #, fuzzy | |
| msgid "Delete all Patches?" | |
| msgstr "Auto-salvar" | |
| #: src/gui/widgets/patches.cc:112 | |
| #, fuzzy | |
| msgid "Delete##patches" | |
| msgstr "Auto-salvar" | |
| #: src/gui/widgets/patches.cc:35 | |
| msgid "Patching is only available in Interpreted CPU mode" | |
| msgstr "O patch só está disponível no modo de CPU interpretada" | |
| #: src/gui/widgets/patches.cc:68 | |
| #, fuzzy | |
| msgid "Delete Patch?" | |
| msgstr "Excluir patch?" | |
| #: src/gui/widgets/patches.cc:69 | |
| #, fuzzy | |
| msgid "Delete" | |
| msgstr "Excluir" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "NOP" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "Return" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:96 | |
| msgid "Activate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:101 | |
| msgid "Deactivate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:107 | |
| #, fuzzy | |
| msgid "Delete All" | |
| msgstr "Excluir tudo" | |
| #: src/gui/widgets/patches.cc:111 | |
| #, fuzzy | |
| msgid "Delete all Patches?" | |
| msgstr "Excluir todos os patches?" | |
| #: src/gui/widgets/patches.cc:112 | |
| #, fuzzy | |
| msgid "Delete##patches" | |
| msgstr "Auto-salvar" |
nicolasnoble
force-pushed
the
chores-i18n
branch
from
e4bd452 to
c76bf33
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/fr.po
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: aur-build
- GitHub Check: build
- GitHub Check: coverage
- GitHub Check: asan
- GitHub Check: toolchain
- GitHub Check: build-openbios
🔇 Additional comments (6)
i18n/pcsx-redux.pot (1)
3092-3127: LGTM! New message strings for patch management look good.The new strings provide a complete set of UI messages for patch management functionality, including:
- Mode requirement warning
- Confirmation dialogs
- Action buttons
i18n/el.po (1)
1235-1239:⚠️ Potential issueFix fuzzy translation for "Show Patches"
The translation incorrectly reuses "Ένδειξη καταχωρητών" (Show Registers) for "Show Patches". This should be properly translated.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
407-416:⚠️ Potential issueFix fuzzy translations for unaligned address messages
The translations for unaligned LWC2/SWC2 address errors incorrectly reuse LW/SW translations.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
3241-3285:⚠️ Potential issueFix incorrect Chinese translations for patch management
Several strings are either missing translations or incorrectly reuse "自动保存" (Auto Save):
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/pt_BR.po (2)
935-942: Missing translations for texture disable options.The texture disable options still lack Portuguese translations.
3284-3328: Inconsistent translations for patch-related strings.Several patch-related strings are still using incorrect translations, reusing "Auto-salvar" for delete operations.
nicolasnoble
force-pushed
the
chores-i18n
branch
from
c76bf33 to
f0521e7
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (5)
i18n/el.po (3)
1235-1239: 🛠️ Refactor suggestionMissing Greek translation for "Show Patches"
The translation for "Show Patches" is marked as fuzzy and incorrectly reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"
400-411: 🛠️ Refactor suggestionMissing Greek translations for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors are currently untranslated (empty msgstr). These should be translated to Greek to maintain consistency in the localization.
Add Greek translations for:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"
3127-3166: 🛠️ Refactor suggestionAdd missing Greek translations for patch management
Several new strings for patch management functionality lack translations:
- "Patching is only available in Interpreted CPU mode"
- "Delete Patch?"
- "Delete"
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
These strings should be translated to maintain consistency in the Greek localization.
i18n/zh_CN.po (2)
407-416: 🛠️ Refactor suggestionChinese translations needed for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors have been marked as fuzzy and reuse translations from LW/SW errors. These should be properly translated to maintain accuracy.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"
3241-3285: 🛠️ Refactor suggestionMissing or fuzzy Chinese translations for patch management
Several new messages related to patch management either lack translations or are marked as fuzzy with incorrect translations:
- "Patching is only available in Interpreted CPU mode" - untranslated
- "Delete Patch?" - fuzzy, using "自动保存"
- "Delete" - fuzzy, using "自动保存"
- "NOP" - untranslated
- "Return" - untranslated
- "Activate All" - untranslated
- "Deactivate All" - untranslated
- "Delete All" - fuzzy, using "自动保存"
- "Delete all Patches?" - fuzzy, using "自动保存"
- "Delete##patches" - fuzzy, using "自动保存"
Add proper Chinese translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"
🧹 Nitpick comments (1)
i18n/fr.po (1)
943-948: Inconsistent translation for "Open Disk Image".The translation "Ouvrir un fichier image" is inconsistent with other similar translations. Consider using "Ouvrir une image disque" to maintain consistency with the terminology.
msgid "Open Disk Image" -msgstr "Ouvrir un fichier image" +msgstr "Ouvrir une image disque"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- i18n/pt_BR.po
- i18n/pcsx-redux.pot
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: cross-arm64
- GitHub Check: asan
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: build
- GitHub Check: aur-build
- GitHub Check: toolchain
- GitHub Check: coverage
🔇 Additional comments (2)
i18n/fr.po (2)
924-931: Missing translations for texture disable options.The following strings need French translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"
1251-1254: Translation "Afficher les Registres" for "Show Patches" is incorrect.The current translation reuses "Show Registers" translation. Based on the translation pattern in the file, it should be "Afficher les correctifs" or "Afficher les patches".
| #: src/gui/gui.cc:1588 | ||
| msgid "Patches" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translation for "Patches".
The string "Patches" should be translated to "Correctifs" or "Patches" in French to maintain consistency with the suggested translation for "Show Patches".
msgid "Patches"
-msgstr ""
+msgstr "Correctifs"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gui/gui.cc:1588 | |
| msgid "Patches" | |
| msgstr "" | |
| #: src/gui/gui.cc:1588 | |
| msgid "Patches" | |
| msgstr "Correctifs" | |
| #: src/gui/widgets/patches.cc:68 | ||
| msgid "Delete Patch?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:69 | ||
| msgid "Delete" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "NOP" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "Return" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:96 | ||
| msgid "Activate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:101 | ||
| msgid "Deactivate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:107 | ||
| msgid "Delete All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:111 | ||
| msgid "Delete all Patches?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:112 | ||
| msgid "Delete##patches" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for patch-related strings.
Several patch-related strings need French translations to maintain consistency:
msgid "Delete Patch?"
-msgstr ""
+msgstr "Supprimer le correctif ?"
msgid "Delete"
-msgstr ""
+msgstr "Supprimer"
msgid "NOP"
-msgstr ""
+msgstr "NOP"
msgid "Return"
-msgstr ""
+msgstr "Retour"
msgid "Activate All"
-msgstr ""
+msgstr "Tout activer"
msgid "Deactivate All"
-msgstr ""
+msgstr "Tout désactiver"
msgid "Delete All"
-msgstr ""
+msgstr "Tout supprimer"
msgid "Delete all Patches?"
-msgstr ""
+msgstr "Supprimer tous les correctifs ?"
msgid "Delete##patches"
-msgstr ""
+msgstr "Supprimer"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gui/widgets/patches.cc:68 | |
| msgid "Delete Patch?" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:69 | |
| msgid "Delete" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "NOP" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "Return" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:96 | |
| msgid "Activate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:101 | |
| msgid "Deactivate All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:107 | |
| msgid "Delete All" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:111 | |
| msgid "Delete all Patches?" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:112 | |
| msgid "Delete##patches" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:68 | |
| msgid "Delete Patch?" | |
| msgstr "Supprimer le correctif ?" | |
| #: src/gui/widgets/patches.cc:69 | |
| msgid "Delete" | |
| msgstr "Supprimer" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "NOP" | |
| msgstr "NOP" | |
| #: src/gui/widgets/patches.cc:88 | |
| msgid "Return" | |
| msgstr "Retour" | |
| #: src/gui/widgets/patches.cc:96 | |
| msgid "Activate All" | |
| msgstr "Tout activer" | |
| #: src/gui/widgets/patches.cc:101 | |
| msgid "Deactivate All" | |
| msgstr "Tout désactiver" | |
| #: src/gui/widgets/patches.cc:107 | |
| msgid "Delete All" | |
| msgstr "Tout supprimer" | |
| #: src/gui/widgets/patches.cc:111 | |
| msgid "Delete all Patches?" | |
| msgstr "Supprimer tous les correctifs ?" | |
| #: src/gui/widgets/patches.cc:112 | |
| msgid "Delete##patches" | |
| msgstr "Supprimer" |
nicolasnoble
force-pushed
the
chores-i18n
branch
from
f0521e7 to
1b88cd8
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
i18n/fr.po (1)
138-142: Add translations for missing system messages.The following messages need translation:
- Kernel checker messages (lines 138-142, 169-175)
- Unaligned address messages (lines 406-415)
Example translations:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Saut de 0x%08x à 0x%08x\n" msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Lecture de %08x depuis %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Écriture vers %08x depuis %08x\n" msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"Also applies to: 169-175, 406-415
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pt_BR.po
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: macos-arm-build-and-test
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: asan
- GitHub Check: build
- GitHub Check: cross-arm64
- GitHub Check: aur-build
- GitHub Check: coverage
- GitHub Check: toolchain
- GitHub Check: macos-build-and-test-toolchain
🔇 Additional comments (10)
i18n/el.po (3)
400-411: 🛠️ Refactor suggestionAdd Greek translations for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors are currently untranslated (empty msgstr). These should be translated to Greek to maintain consistency in the localization.
Add Greek translations for:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"Likely invalid or redundant comment.
1235-1239: 🛠️ Refactor suggestionFix fuzzy translation for Show Patches
The translation for "Show Patches" is marked as fuzzy and currently reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
3127-3166: 🛠️ Refactor suggestionAdd missing Greek translations for patch management
Several new strings for patch management functionality lack translations:
- "Patching is only available in Interpreted CPU mode"
- "Delete Patch?"
- "Delete"
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
Add proper Greek translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Η επιδιόρθωση είναι διαθέσιμη μόνο σε λειτουργία Interpreted CPU" msgid "Delete Patch?" -msgstr "" +msgstr "Διαγραφή επιδιόρθωσης;" msgid "Delete" -msgstr "" +msgstr "Διαγραφή" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Επιστροφή" msgid "Activate All" -msgstr "" +msgstr "Ενεργοποίηση όλων" msgid "Deactivate All" -msgstr "" +msgstr "Απενεργοποίηση όλων" msgid "Delete All" -msgstr "" +msgstr "Διαγραφή όλων" msgid "Delete all Patches?" -msgstr "" +msgstr "Διαγραφή όλων των επιδιορθώσεων;" msgid "Delete##patches" -msgstr "" +msgstr "Διαγραφή##επιδιορθώσεων"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
407-416: 🛠️ Refactor suggestionFix Chinese translations for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors are marked as fuzzy and reuse translations from LW/SW errors. These should be properly translated to maintain accuracy.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
3241-3285: 🛠️ Refactor suggestionFix Chinese translations for patch management
Several new messages related to patch management either lack translations or are marked as fuzzy with incorrect translations:
- "Patching is only available in Interpreted CPU mode" - untranslated
- "Delete Patch?" - fuzzy, using "自动保存"
- "Delete" - fuzzy, using "自动保存"
- "NOP" - untranslated
- "Return" - untranslated
- "Activate All" - untranslated
- "Deactivate All" - untranslated
- "Delete All" - fuzzy, using "自动保存"
- "Delete all Patches?" - fuzzy, using "自动保存"
- "Delete##patches" - fuzzy, using "自动保存"
Add proper Chinese translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/fr.po (1)
924-931: Missing and incorrect translations for patch-related strings.The following translations need to be addressed:
- "Disable textures for polygons/sprites" needs translation
- "Show Patches" is incorrectly translated as "Afficher les Registres"
- "Patches" needs translation
- Several patch-related strings like "Delete Patch?", "Delete", "NOP", etc. need translation
Also applies to: 1251-1254, 1456-1459, 3248-3283
i18n/pcsx-redux.pot (4)
393-401: Add missing translations for unaligned address messagesNew messages for unaligned LWC2/SWC2 address errors have been added but lack translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" msgstr "" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" msgstr ""These messages should be translated in all localization files to maintain consistency. The format strings
0x%08xshould be preserved in the same order in translations.
903-909: Add missing translations for texture disable messagesNew messages for disabling textures lack translations:
msgid "Disable textures for polygons" msgstr "" msgid "Disable textures for sprites" msgstr ""These UI messages should be translated in all localization files to maintain consistency.
1215-1217: Add translation for patch management messageThe new message for showing patches needs translation:
msgid "Show Patches" msgstr ""
Line range hint
1-3665: LGTM! The localization template has been properly regenerated.The changes appropriately update the line numbers in source file references and add new message strings for recent functionality additions.
nicolasnoble
force-pushed
the
chores-i18n
branch
from
1b88cd8 to
40bdd27
Compare
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pcsx-redux.pot
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (7)
i18n/el.po (2)
1235-1239: 🛠️ Refactor suggestionFuzzy translation for "Show Patches"
The translation for "Show Patches" is marked as fuzzy and incorrectly reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
400-411: 🛠️ Refactor suggestionGreek translations needed for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors are currently untranslated (empty msgstr). These should be translated to Greek to maintain consistency in the localization.
Add Greek translations for:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
407-416: 🛠️ Refactor suggestionChinese translations needed for unaligned address messages
The new messages for unaligned LWC2/SWC2 address errors have been marked as fuzzy and reuse translations from LW/SW errors. These should be properly translated to maintain accuracy.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
3241-3285: 🛠️ Refactor suggestionMissing or fuzzy Chinese translations for patch management
Several new messages related to patch management either lack translations or are marked as fuzzy with incorrect translations:
- "Patching is only available in Interpreted CPU mode" - untranslated
- "Delete Patch?" - fuzzy, using "自动保存"
- "Delete" - fuzzy, using "自动保存"
- "NOP" - untranslated
- "Return" - untranslated
- "Activate All" - untranslated
- "Deactivate All" - untranslated
- "Delete All" - fuzzy, using "自动保存"
- "Delete all Patches?" - fuzzy, using "自动保存"
- "Delete##patches" - fuzzy, using "自动保存"
Add proper Chinese translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/fr.po (1)
924-931: Missing translations for texture disable options.The new texture disable options lack French translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"i18n/pt_BR.po (2)
935-942: Missing translations for texture disable options.The new texture disable options lack Portuguese translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Desativar texturas para polígonos" msgid "Disable textures for sprites" -msgstr "" +msgstr "Desativar texturas para sprites"
3284-3328:⚠️ Potential issueInconsistent translations for patch-related strings.
Several patch-related strings are either missing translations or incorrectly reusing "Auto-salvar":
Apply these fixes:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "O patch só está disponível no modo de CPU interpretada" msgid "Delete Patch?" -msgstr "Auto-salvar" +msgstr "Excluir patch?" msgid "Delete" -msgstr "Auto-salvar" +msgstr "Excluir" msgid "Delete All" -msgstr "Auto-salvar" +msgstr "Excluir tudo" msgid "Delete all Patches?" -msgstr "Auto-salvar" +msgstr "Excluir todos os patches?"Likely invalid or redundant comment.
| #: src/gui/widgets/patches.cc:35 | ||
| msgid "Patching is only available in Interpreted CPU mode" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:68 | ||
| msgid "Delete Patch?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:69 | ||
| msgid "Delete" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "NOP" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "Return" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:96 | ||
| msgid "Activate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:101 | ||
| msgid "Deactivate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:107 | ||
| msgid "Delete All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:111 | ||
| msgid "Delete all Patches?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:112 | ||
| msgid "Delete##patches" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add missing Greek translations for patch management
Several new strings for patch management functionality lack translations:
- "Patching is only available in Interpreted CPU mode"
- "Delete Patch?"
- "Delete"
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
These strings should be translated to maintain consistency in the Greek localization.
| msgstr "Break on execution map" | ||
|
|
||
| #: src/core/debug.cc:119 | ||
| #: src/core/debug.cc:166 | ||
| #, c-format | ||
| msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for kernel checker messages.
The following kernel checker messages need French translations:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Saut de 0x%08x vers 0x%08x\n"
msgid "Kernel checker: Reading %08x from %08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Lecture de %08x depuis %08x\n"
msgid "Kernel checker: Writing to %08x from %08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Écriture vers %08x depuis %08x\n"Also applies to: 166-176
| #, fuzzy | ||
| msgid "Show Patches" | ||
| msgstr "Afficher les Registres" | ||
|
|
There was a problem hiding this comment.
Translation "Afficher les Registres" for "Show Patches" is incorrect.
The current translation reuses "Show Registers" translation. Based on the translation pattern in the file, it should be "Afficher les correctifs" or "Afficher les patches".
Apply this diff:
msgid "Show Patches"
-msgstr "Afficher les Registres"
+msgstr "Afficher les correctifs"
msgid "Patches"
-msgstr ""
+msgstr "Correctifs"Also applies to: 1456-1459
| #, c-format | ||
| msgid "CD-ROM EXE Name: %.255s\n" | ||
| msgstr "Nom de l'EXE du CD-ROM : %.255s\n" | ||
|
|
||
| #: src/core/debug.cc:89 | ||
| #: src/core/debug.cc:151 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Correct the fuzzy translations.
The following translations need review:
- "Execution map" should be "Carte d'exécution" instead of "Break on execution map"
- "Dithering" should be "Tramage" instead of "version OpenGL"
- "Output mode" should be "Mode de sortie" instead of "Sortie"
- "Interlaced" should be "Entrelacé" instead of "Erreur lors de l'ouverture du fichier : %s.\n"
Also applies to: 302-302, 361-361, 379-379
| #: src/core/debug.cc:166 | ||
| #, c-format | ||
| msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for kernel checker messages.
The following kernel checker messages need Portuguese translations:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n"
-msgstr ""
+msgstr "Verificador do Kernel: Salto de 0x%08x para 0x%08x\n"
msgid "Kernel checker: Reading %08x from %08x\n"
-msgstr ""
+msgstr "Verificador do Kernel: Lendo %08x de %08x\n"
msgid "Kernel checker: Writing to %08x from %08x\n"
-msgstr ""
+msgstr "Verificador do Kernel: Gravando em %08x de %08x\n"Also applies to: 166-174
nicolasnoble
force-pushed
the
chores-i18n
branch
2 times, most recently
from
cf8765e to
8293488
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pt_BR.po
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (10)
i18n/el.po (3)
1235-1239: 🛠️ Refactor suggestionFix fuzzy translation for "Show Patches".
The translation for "Show Patches" is incorrectly marked as fuzzy and reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
400-409: 🛠️ Refactor suggestionAdd Greek translations for unaligned address messages.
The new messages for unaligned LWC2/SWC2 address errors are currently untranslated. These should be translated to maintain consistency.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"Likely invalid or redundant comment.
3127-3166: 🛠️ Refactor suggestionAdd Greek translations for patch management strings.
Several new strings for patch management functionality lack translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Η επιδιόρθωση είναι διαθέσιμη μόνο σε λειτουργία Interpreted CPU" msgid "Delete Patch?" -msgstr "" +msgstr "Διαγραφή επιδιόρθωσης;" msgid "Delete" -msgstr "" +msgstr "Διαγραφή" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Επιστροφή" msgid "Activate All" -msgstr "" +msgstr "Ενεργοποίηση όλων" msgid "Deactivate All" -msgstr "" +msgstr "Απενεργοποίηση όλων" msgid "Delete All" -msgstr "" +msgstr "Διαγραφή όλων" msgid "Delete all Patches?" -msgstr "" +msgstr "Διαγραφή όλων των επιδιορθώσεων;" msgid "Delete##patches" -msgstr "" +msgstr "Διαγραφή##επιδιορθώσεις"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
407-416: 🛠️ Refactor suggestionFix incorrect translations for unaligned address messages.
The translations for unaligned LWC2/SWC2 address errors are incorrectly reusing translations from LW/SW errors. These should be properly translated.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
3241-3285: 🛠️ Refactor suggestionFix incorrect Chinese translations for patch management strings.
Several strings are marked as fuzzy and incorrectly reuse "自动保存" (auto save) translation. These need proper translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/fr.po (2)
924-931: Missing translations for patching functionality.Several strings related to patching functionality need French translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygons" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites" msgid "Patches" -msgstr "" +msgstr "Correctifs" msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le correctif ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les correctifs ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer"Also applies to: 1456-1459, 3248-3283
133-133: Review and correct fuzzy translations.The following translations are marked as fuzzy and need review:
msgid "Execution map" -msgstr "Break on execution map" +msgstr "Carte d'exécution" msgid "Dithering: %s" -msgstr "version OpenGL" +msgstr "Tramage : %s" msgid "Output mode: %s" -msgstr "Sortie" +msgstr "Mode de sortie : %s" msgid "Interlaced: %s" -msgstr "Erreur lors de l'ouverture du fichier : %s.\n" +msgstr "Entrelacé : %s"Also applies to: 302-302, 361-361, 379-379
i18n/pcsx-redux.pot (3)
1215-1217: Add translations for patch management messagesThese new messages for patch management functionality need translations:
msgid "Patching is only available in Interpreted CPU mode" msgstr "" msgid "Delete Patch?" msgstr "" msgid "Delete" msgstr "" msgid "NOP" msgstr "" msgid "Return" msgstr "" msgid "Activate All" msgstr "" msgid "Deactivate All" msgstr "" msgid "Delete All" msgstr "" msgid "Delete all Patches?" msgstr ""Also applies to: 3092-3131
393-401: Add translations for unaligned address messagesNew messages for unaligned LWC2/SWC2 address errors need translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" msgstr "" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" msgstr ""The format strings
0x%08xshould be preserved in the same order in translations.
Line range hint
1-24: LGTM! File structure and format are correct.The PO template file follows the standard gettext format with proper header information and consistent encoding.
| #: src/gui/widgets/patches.cc:35 | ||
| msgid "Patching is only available in Interpreted CPU mode" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translation for CPU mode message.
Add French translation for the CPU mode message:
msgid "Patching is only available in Interpreted CPU mode"
-msgstr ""
+msgstr "Les correctifs ne sont disponibles qu'en mode CPU interprété"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gui/widgets/patches.cc:35 | |
| msgid "Patching is only available in Interpreted CPU mode" | |
| msgstr "" | |
| #: src/gui/widgets/patches.cc:35 | |
| msgid "Patching is only available in Interpreted CPU mode" | |
| msgstr "Les correctifs ne sont disponibles qu'en mode CPU interprété" | |
| #: src/gui/widgets/registers.cc:396 | ||
| msgid "Bus Error" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:399 | ||
| msgid "DMA IRQ Enabled" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:402 | ||
| msgid "DMA IRQ Triggered" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:408 | ||
| msgid "Completion" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:411 | ||
| msgid "IRQ Enabled" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:414 | ||
| msgid "Triggered" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add translations for register status messages
New messages for register status flags need translations:
msgid "Bus Error"
msgstr ""
msgid "DMA IRQ Enabled"
msgstr ""
msgid "DMA IRQ Triggered"
msgstr ""
msgid "Completion"
msgstr ""
msgid "IRQ Enabled"
msgstr ""
msgid "Triggered"
msgstr ""
91136a8 to
3ac45d5
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (3)
i18n/zh_CN.po (3)
Line range hint
903-910: Add missing translations for texture disable options.The new texture disable options need Chinese translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "禁用多边形纹理" msgid "Disable textures for sprites" -msgstr "" +msgstr "禁用精灵纹理"
Line range hint
3092-3131: Add missing translations for patch management UI.Several patch-related strings need Chinese translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "" +msgstr "删除补丁？" msgid "Delete" -msgstr "" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "" +msgstr "删除##补丁"
Line range hint
3181-3204: Add missing translations for register status flags.The register status messages need Chinese translations:
msgid "Bus Error" -msgstr "" +msgstr "总线错误" msgid "DMA IRQ Enabled" -msgstr "" +msgstr "DMA IRQ 已启用" msgid "DMA IRQ Triggered" -msgstr "" +msgstr "DMA IRQ 已触发" msgid "Completion" -msgstr "" +msgstr "完成" msgid "IRQ Enabled" -msgstr "" +msgstr "IRQ 已启用" msgid "Triggered" -msgstr "" +msgstr "已触发"
🧹 Nitpick comments (2)
i18n/pt_BR.po (2)
1238-1242: Consider simplifying the translation for better readability.The current translation "Mostrar as Pilhas de Chamadas" is overly formal. Consider using a simpler translation:
msgid "Show Callstacks" -msgstr "Mostrar as Pilhas de Chamadas" +msgstr "Mostrar Pilhas de Chamada"
1036-1036: Maintain consistent capitalization in menu items.Menu items should follow consistent capitalization rules. Currently, some items start with lowercase while others are capitalized:
msgid "Output" -msgstr "Saída" +msgstr "Saída" msgid "Controls" msgstr "Controles" msgid "UI" msgstr "Interface do Usuário"Consider standardizing the capitalization across all menu items.
Also applies to: 1147-1147, 1163-1163
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/el.po
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: aur-build
- GitHub Check: build-openbios
- GitHub Check: asan
- GitHub Check: build
- GitHub Check: cross-arm64
- GitHub Check: coverage
- GitHub Check: toolchain
- GitHub Check: macos-build-and-test-toolchain
🔇 Additional comments (7)
i18n/zh_CN.po (1)
407-416:⚠️ Potential issueFix incorrect translations for unaligned LWC2/SWC2 messages.
The translations for unaligned LWC2/SWC2 address messages are incorrectly reusing LW/SW translations. They should be properly translated:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
i18n/fr.po (2)
924-931: 🛠️ Refactor suggestionAdd missing translations for texture disable options.
The texture disable options need French translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"Likely invalid or redundant comment.
3244-3283: 🛠️ Refactor suggestionAdd missing translations for patch management UI.
Several patch-related strings need French translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Les correctifs ne sont disponibles qu'en mode CPU interprété" msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le correctif ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les correctifs ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer"Likely invalid or redundant comment.
i18n/pcsx-redux.pot (1)
Line range hint
1-3851: Template file structure looks good.The template file contains all the necessary message IDs and is properly formatted for use as a translation template.
i18n/pt_BR.po (3)
136-140: Missing translations for kernel checker messages.The following kernel checker messages still lack Portuguese translations:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Verificador do Kernel: Salto de 0x%08x para 0x%08x\n" msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Lendo %08x de %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Gravando em %08x de %08x\n"Also applies to: 166-174
935-942: Missing translations for texture disable options.The texture disable options still lack Portuguese translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Desativar texturas para polígonos" msgid "Disable textures for sprites" -msgstr "" +msgstr "Desativar texturas para sprites"
3284-3328: Inconsistent translations for patch-related strings.Several patch-related strings are either missing translations or incorrectly reusing "Auto-salvar":
Apply these fixes:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "O patch só está disponível no modo de CPU interpretada" msgid "Delete Patch?" -msgstr "Auto-salvar" +msgstr "Excluir patch?" msgid "Delete" -msgstr "Auto-salvar" +msgstr "Excluir" msgid "Delete All" -msgstr "Auto-salvar" +msgstr "Excluir tudo" msgid "Delete all Patches?" -msgstr "Auto-salvar" +msgstr "Excluir todos os patches?"
| #, c-format | ||
| msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" | ||
| msgstr "" | ||
|
|
||
| #: src/core/gte.h:69 | ||
| #, c-format | ||
| msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" | ||
| msgstr "" | ||
|
|
||
| #: src/core/memorycard.cc:348 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add missing translations for unaligned LWC2/SWC2 messages.
The unaligned address messages need French translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n"
-msgstr ""
+msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n"
msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n"
-msgstr ""
+msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #, c-format | |
| msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" | |
| msgstr "" | |
| #: src/core/gte.h:69 | |
| #, c-format | |
| msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" | |
| msgstr "" | |
| #: src/core/memorycard.cc:348 | |
| #, c-format | |
| msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" | |
| msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" | |
| #: src/core/gte.h:69 | |
| #, c-format | |
| msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" | |
| msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n" | |
| #: src/core/memorycard.cc:348 |
| #: src/gui/widgets/registers.cc:396 | ||
| msgid "Bus Error" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:399 | ||
| #, fuzzy | ||
| msgid "DMA IRQ Enabled" | ||
| msgstr "Désactivé" | ||
|
|
||
| #: src/gui/widgets/registers.cc:402 | ||
| msgid "DMA IRQ Triggered" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/registers.cc:408 | ||
| #, fuzzy | ||
| msgid "Completion" | ||
| msgstr "Emulation" | ||
|
|
||
| #: src/gui/widgets/registers.cc:411 | ||
| #, fuzzy | ||
| msgid "IRQ Enabled" | ||
| msgstr "Désactivé" | ||
|
|
||
| #: src/gui/widgets/registers.cc:414 | ||
| msgid "Triggered" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add missing translations for register status flags.
The register status messages need French translations:
msgid "Bus Error"
-msgstr ""
+msgstr "Erreur de bus"
msgid "DMA IRQ Enabled"
-msgstr ""
+msgstr "IRQ DMA activée"
msgid "DMA IRQ Triggered"
-msgstr ""
+msgstr "IRQ DMA déclenchée"
msgid "Completion"
-msgstr ""
+msgstr "Terminé"
msgid "IRQ Enabled"
-msgstr ""
+msgstr "IRQ activée"
msgid "Triggered"
-msgstr ""
+msgstr "Déclenché"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #: src/gui/widgets/registers.cc:396 | |
| msgid "Bus Error" | |
| msgstr "" | |
| #: src/gui/widgets/registers.cc:399 | |
| #, fuzzy | |
| msgid "DMA IRQ Enabled" | |
| msgstr "Désactivé" | |
| #: src/gui/widgets/registers.cc:402 | |
| msgid "DMA IRQ Triggered" | |
| msgstr "" | |
| #: src/gui/widgets/registers.cc:408 | |
| #, fuzzy | |
| msgid "Completion" | |
| msgstr "Emulation" | |
| #: src/gui/widgets/registers.cc:411 | |
| #, fuzzy | |
| msgid "IRQ Enabled" | |
| msgstr "Désactivé" | |
| #: src/gui/widgets/registers.cc:414 | |
| msgid "Triggered" | |
| msgstr "" | |
| #: src/gui/widgets/registers.cc:396 | |
| msgid "Bus Error" | |
| msgstr "Erreur de bus" | |
| #: src/gui/widgets/registers.cc:399 | |
| #, fuzzy | |
| msgid "DMA IRQ Enabled" | |
| msgstr "IRQ DMA activée" | |
| #: src/gui/widgets/registers.cc:402 | |
| msgid "DMA IRQ Triggered" | |
| msgstr "IRQ DMA déclenchée" | |
| #: src/gui/widgets/registers.cc:408 | |
| #, fuzzy | |
| msgid "Completion" | |
| msgstr "Terminé" | |
| #: src/gui/widgets/registers.cc:411 | |
| #, fuzzy | |
| msgid "IRQ Enabled" | |
| msgstr "IRQ activée" | |
| #: src/gui/widgets/registers.cc:414 | |
| msgid "Triggered" | |
| msgstr "Déclenché" |
nicolasnoble
force-pushed
the
chores-i18n
branch
from
3ac45d5 to
77f72d2
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (6)
i18n/fr.po (3)
924-931: 🛠️ Refactor suggestionMissing translations for texture disable options.
The new texture disable options lack French translations.
Apply this diff:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"
1251-1254:⚠️ Potential issueTranslation "Afficher les Registres" for "Show Patches" is incorrect.
The current translation reuses "Show Registers" translation. Based on the translation pattern in the file, it should be "Afficher les correctifs" or "Afficher les patches".
Apply this diff:
msgid "Show Patches" -msgstr "Afficher les Registres" +msgstr "Afficher les correctifs" msgid "Patches" -msgstr "" +msgstr "Correctifs"
3244-3283: 🛠️ Refactor suggestionMissing translations for patch-related strings.
Several patch-related strings need French translations to maintain consistency.
Apply this diff:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Les correctifs ne sont disponibles qu'en mode CPU interprété" msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le correctif ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les correctifs ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer"i18n/pt_BR.po (3)
138-140: 🛠️ Refactor suggestionMissing translations for kernel checker messages.
The kernel checker messages need Portuguese translations to maintain consistency.
Apply this diff:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Verificador do Kernel: Salto de 0x%08x para 0x%08x\n" msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Lendo %08x de %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Gravando em %08x de %08x\n"Also applies to: 167-174
935-942: 🛠️ Refactor suggestionMissing translations for texture disable options.
The new texture disable options lack Portuguese translations.
Apply this diff:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Desativar texturas para polígonos" msgid "Disable textures for sprites" -msgstr "" +msgstr "Desativar texturas para sprites"
3284-3328:⚠️ Potential issueInconsistent translations for patch-related strings.
Several patch-related strings are either missing translations or incorrectly reusing "Auto-salvar".
Apply this diff:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "O patch só está disponível no modo de CPU interpretada" msgid "Delete Patch?" -msgstr "Auto-salvar" +msgstr "Excluir patch?" msgid "Delete" -msgstr "Auto-salvar" +msgstr "Excluir" msgid "Delete All" -msgstr "Auto-salvar" +msgstr "Excluir tudo" msgid "Delete all Patches?" -msgstr "Auto-salvar" +msgstr "Excluir todos os patches?"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🔇 Additional comments (5)
i18n/el.po (1)
1235-1239: 🛠️ Refactor suggestionFix fuzzy translation for "Show Patches".
The translation for "Show Patches" is marked as fuzzy and incorrectly reuses the translation for "Show Registers". This should be updated with a proper Greek translation.
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
3241-3285: 🛠️ Refactor suggestionAdd missing Chinese translations for patch management.
Several new messages for patch management functionality either lack translations or are marked as fuzzy with incorrect translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
407-416: 🛠️ Refactor suggestionFix fuzzy translations for unaligned address messages.
The translations for unaligned LWC2/SWC2 address errors are marked as fuzzy and incorrectly reuse translations from LW/SW errors. These should be updated with proper Chinese translations.
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
i18n/fr.po (1)
407-414: 🛠️ Refactor suggestionAdd missing translations for unaligned LWC2/SWC2 messages.
The unaligned address messages need French translations.
Apply this diff:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"Likely invalid or redundant comment.
i18n/pt_BR.po (1)
407-414: LGTM! Unaligned memory access messages are properly translated.The translations for unaligned address messages in LWC2/SWC2 are accurate and consistent.
| #: src/core/debug.cc:166 | ||
| #, c-format | ||
| msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" | ||
| msgstr "" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Missing translations for kernel checker messages.
The kernel checker messages need French translations to maintain consistency.
Apply this diff:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Saut de 0x%08x vers 0x%08x\n"
msgid "Kernel checker: Reading %08x from %08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Lecture de %08x depuis %08x\n"
msgid "Kernel checker: Writing to %08x from %08x\n"
-msgstr ""
+msgstr "Vérificateur du noyau : Écriture vers %08x depuis %08x\n"Also applies to: 167-174
nicolasnoble
force-pushed
the
chores-i18n
branch
from
77f72d2 to
7ba10ac
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (10)
i18n/el.po (2)
1235-1239: 🛠️ Refactor suggestionMissing Greek translations for patch management
The new patch management strings are either untranslated or using incorrect translations:
- "Show Patches" is marked as fuzzy and incorrectly reuses "Ένδειξη καταχωρητών" (Show Registers)
- Other patch management strings are completely untranslated
Please provide proper Greek translations for these strings.
400-409: 🛠️ Refactor suggestionMissing Greek translations for unaligned memory messages
The new unaligned memory access error messages are untranslated:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" msgstr "" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" msgstr ""Please provide Greek translations for these error messages.
i18n/zh_CN.po (2)
3241-3285: 🛠️ Refactor suggestionIncorrect Chinese translations for patch management
Several patch management strings are marked as fuzzy and incorrectly reuse "自动保存" (Auto save):
- "Delete Patch?"
- "Delete"
- "Delete All"
- "Delete all Patches?"
- "Delete##patches"
Other strings are completely untranslated:
- "NOP"
- "Return"
- "Activate All"
- "Deactivate All"
Please provide proper Chinese translations for these strings.
407-416: 🛠️ Refactor suggestionIncorrect Chinese translations for unaligned memory messages
The unaligned memory access error messages are marked as fuzzy and incorrectly reuse translations from LW/SW errors:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Please update the translations to correctly reference LWC2/SWC2 instructions.
i18n/fr.po (3)
3244-3283: 🛠️ Refactor suggestionMissing translations for patch-related strings.
Several patch-related strings need French translations to maintain consistency.
Apply this diff:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Le patch n'est disponible qu'en mode CPU interprété" msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le correctif ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les correctifs ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer"
924-931: 🛠️ Refactor suggestionMissing translations for texture disable options.
The texture disable options lack French translations.
Apply this diff:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"
138-174: 🛠️ Refactor suggestionMissing translations for kernel checker messages.
The kernel checker messages need French translations to maintain consistency.
Apply this diff:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Saut de 0x%08x vers 0x%08x\n" msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Lecture de %08x depuis %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Écriture vers %08x depuis %08x\n"i18n/pt_BR.po (3)
3284-3328:⚠️ Potential issueInconsistent translations for patch-related strings.
Several patch-related strings are either missing translations or incorrectly reusing "Auto-salvar".
Apply this diff:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "O patch só está disponível no modo de CPU interpretada" msgid "Delete Patch?" -msgstr "Auto-salvar" +msgstr "Excluir patch?" msgid "Delete" -msgstr "Auto-salvar" +msgstr "Excluir" msgid "Delete All" -msgstr "Auto-salvar" +msgstr "Excluir tudo" msgid "Delete all Patches?" -msgstr "Auto-salvar" +msgstr "Excluir todos os patches?"
935-942: 🛠️ Refactor suggestionMissing translations for texture disable options.
The texture disable options lack Portuguese translations.
Apply this diff:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Desativar texturas para polígonos" msgid "Disable textures for sprites" -msgstr "" +msgstr "Desativar texturas para sprites"
136-174: 🛠️ Refactor suggestionMissing translations for kernel checker messages.
The kernel checker messages need Portuguese translations to maintain consistency.
Apply this diff:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Verificador do Kernel: Salto de 0x%08x para 0x%08x\n" msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Lendo %08x de %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Verificador do Kernel: Gravando em %08x de %08x\n"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: macos-arm-build-and-test
- GitHub Check: coverage
- GitHub Check: aur-build
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: build
- GitHub Check: toolchain
- GitHub Check: asan
- GitHub Check: cross-arm64
🔇 Additional comments (2)
i18n/fr.po (1)
407-414: 🛠️ Refactor suggestionMissing translations for unaligned LWC2/SWC2 messages.
The unaligned address messages need French translations to maintain consistency with other similar messages in the file.
Apply this diff:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"Likely invalid or redundant comment.
i18n/pt_BR.po (1)
405-414: LGTM! Remove fuzzy flags.The translations for unaligned address messages are accurate. The fuzzy flags can be safely removed.
nicolasnoble
force-pushed
the
chores-i18n
branch
from
7ba10ac to
b46ca31
Compare
nicolasnoble
force-pushed
the
chores-i18n
branch
from
b46ca31 to
27ecefd
Compare
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
i18n/el.po(25 hunks)i18n/fr.po(23 hunks)i18n/pcsx-redux.pot(23 hunks)i18n/pt_BR.po(36 hunks)i18n/zh_CN.po(35 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- i18n/pt_BR.po
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: toolchain
- GitHub Check: macos-build-and-test-toolchain
- GitHub Check: aur-build
- GitHub Check: asan
- GitHub Check: coverage
- GitHub Check: build
- GitHub Check: cross-arm64
🔇 Additional comments (16)
i18n/el.po (3)
1235-1239:⚠️ Potential issueIncorrect fuzzy translation for Show Patches
The translation for "Show Patches" is marked as fuzzy and incorrectly reuses the translation for "Show Registers":
msgid "Show Patches" -msgstr "Ένδειξη καταχωρητών" +msgstr "Εμφάνιση επιδιορθώσεων"Likely invalid or redundant comment.
400-409: 🛠️ Refactor suggestionMissing Greek translations for unaligned memory errors
The new unaligned memory access error messages are untranslated:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο LWC2 από 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Μη ευθυγραμμισμένη διεύθυνση 0x%08x στο SWC2 από 0x%08x\n"Likely invalid or redundant comment.
3127-3166: 🛠️ Refactor suggestionMissing Greek translations for patch management
Several new strings for patch management functionality lack translations:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Η εφαρμογή επιδιορθώσεων είναι διαθέσιμη μόνο σε λειτουργία Interpreted CPU" msgid "Delete Patch?" -msgstr "" +msgstr "Διαγραφή επιδιόρθωσης;" msgid "Delete" -msgstr "" +msgstr "Διαγραφή" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Επιστροφή" msgid "Activate All" -msgstr "" +msgstr "Ενεργοποίηση όλων" msgid "Deactivate All" -msgstr "" +msgstr "Απενεργοποίηση όλων" msgid "Delete All" -msgstr "" +msgstr "Διαγραφή όλων" msgid "Delete all Patches?" -msgstr "" +msgstr "Διαγραφή όλων των επιδιορθώσεων;" msgid "Delete##patches" -msgstr "" +msgstr "Διαγραφή##επιδιορθώσεων"Likely invalid or redundant comment.
i18n/zh_CN.po (2)
407-416:⚠️ Potential issueIncorrect fuzzy translations for unaligned memory errors
The translations for unaligned LWC2/SWC2 errors are marked as fuzzy and incorrectly reuse LW/SW translations:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in LW from 0x%08x\n" +msgstr "从 0x%08x 处执行 LWC2 时出现未对齐地址 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "Unaligned address 0x%08x in SW from 0x%08x\n" +msgstr "从 0x%08x 处执行 SWC2 时出现未对齐地址 0x%08x\n"Likely invalid or redundant comment.
3241-3285:⚠️ Potential issueIncorrect fuzzy translations for patch management
Several patch management strings are marked as fuzzy and incorrectly reuse "自动保存" (auto save):
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "补丁功能仅在解释型 CPU 模式下可用" msgid "Delete Patch?" -msgstr "自动保存" +msgstr "删除补丁？" msgid "Delete" -msgstr "自动保存" +msgstr "删除" msgid "NOP" -msgstr "" +msgstr "空操作" msgid "Return" -msgstr "" +msgstr "返回" msgid "Activate All" -msgstr "" +msgstr "激活全部" msgid "Deactivate All" -msgstr "" +msgstr "停用全部" msgid "Delete All" -msgstr "自动保存" +msgstr "删除全部" msgid "Delete all Patches?" -msgstr "自动保存" +msgstr "删除所有补丁？" msgid "Delete##patches" -msgstr "自动保存" +msgstr "删除##补丁"Likely invalid or redundant comment.
i18n/fr.po (11)
3244-3247: 🛠️ Refactor suggestionMissing translation for CPU mode message.
Add French translation for the CPU mode message:
msgid "Patching is only available in Interpreted CPU mode" -msgstr "" +msgstr "Les correctifs ne sont disponibles qu'en mode CPU interprété"Likely invalid or redundant comment.
1251-1254: 🛠️ Refactor suggestionTranslation "Afficher les Registres" for "Show Patches" is incorrect.
The current translation reuses "Show Registers" translation. Based on the translation pattern in the file, it should be "Afficher les correctifs" or "Afficher les patches".
msgid "Show Patches" -msgstr "Afficher les Registres" +msgstr "Afficher les correctifs" msgid "Patches" -msgstr "" +msgstr "Correctifs"Likely invalid or redundant comment.
924-931: 🛠️ Refactor suggestionMissing translations for texture disable options.
The texture disable options need French translations:
msgid "Disable textures for polygons" -msgstr "" +msgstr "Désactiver les textures pour les polygones" msgid "Disable textures for sprites" -msgstr "" +msgstr "Désactiver les textures pour les sprites"Likely invalid or redundant comment.
361-361: 🛠️ Refactor suggestionFix fuzzy translation for "Output mode".
The current translation "Sortie" is incomplete. It should be "Mode de sortie" in French.
#, fuzzy, c-format msgid "Output mode: %s" -msgstr "Sortie" +msgstr "Mode de sortie : %s"Likely invalid or redundant comment.
302-302: 🛠️ Refactor suggestionFix fuzzy translation for "Dithering".
The current translation "version OpenGL" is incorrect for "Dithering". It should be "Tramage" in French.
#, fuzzy, c-format msgid "Dithering: %s" -msgstr "version OpenGL" +msgstr "Tramage : %s"Likely invalid or redundant comment.
167-175: 🛠️ Refactor suggestionMissing translations for kernel checker messages.
The kernel checker messages need French translations:
msgid "Kernel checker: Reading %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Lecture de %08x depuis %08x\n" msgid "Kernel checker: Writing to %08x from %08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Écriture vers %08x depuis %08x\n"Likely invalid or redundant comment.
379-379: 🛠️ Refactor suggestionFix fuzzy translation for "Interlaced".
The current translation is incorrect as it's using an error message. It should be "Entrelacé" in French.
#, fuzzy, c-format msgid "Interlaced: %s" -msgstr "Erreur lors de l'ouverture du fichier : %s.\n" +msgstr "Entrelacé : %s"Likely invalid or redundant comment.
3248-3283: 🛠️ Refactor suggestionMissing translations for patch-related strings.
Several patch-related strings need French translations to maintain consistency:
msgid "Delete Patch?" -msgstr "" +msgstr "Supprimer le correctif ?" msgid "Delete" -msgstr "" +msgstr "Supprimer" msgid "NOP" -msgstr "" +msgstr "NOP" msgid "Return" -msgstr "" +msgstr "Retour" msgid "Activate All" -msgstr "" +msgstr "Tout activer" msgid "Deactivate All" -msgstr "" +msgstr "Tout désactiver" msgid "Delete All" -msgstr "" +msgstr "Tout supprimer" msgid "Delete all Patches?" -msgstr "" +msgstr "Supprimer tous les correctifs ?" msgid "Delete##patches" -msgstr "" +msgstr "Supprimer"Likely invalid or redundant comment.
3337-3363: 🛠️ Refactor suggestionMissing translations for register status flags.
The register status messages need French translations:
msgid "Bus Error" -msgstr "" +msgstr "Erreur de bus" msgid "DMA IRQ Enabled" -msgstr "" +msgstr "IRQ DMA activée" msgid "DMA IRQ Triggered" -msgstr "" +msgstr "IRQ DMA déclenchée" msgid "Completion" -msgstr "" +msgstr "Terminé" msgid "IRQ Enabled" -msgstr "" +msgstr "IRQ activée" msgid "Triggered" -msgstr "" +msgstr "Déclenché"Likely invalid or redundant comment.
407-414: 🛠️ Refactor suggestionMissing translations for unaligned memory access messages.
Add French translations for the unaligned memory access messages:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans LWC2 depuis 0x%08x\n" msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" -msgstr "" +msgstr "Adresse non alignée 0x%08x dans SWC2 depuis 0x%08x\n"Likely invalid or redundant comment.
138-141: 🛠️ Refactor suggestionMissing translations for kernel checker messages.
The kernel checker messages need French translations to maintain consistency:
msgid "Kernel checker: Jump from 0x%08x to 0x%08x\n" -msgstr "" +msgstr "Vérificateur du noyau : Saut de 0x%08x vers 0x%08x\n"Likely invalid or redundant comment.
| #: src/core/gte.h:57 | ||
| #, c-format | ||
| msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n" | ||
| msgstr "" | ||
|
|
||
| #: src/core/gte.h:69 | ||
| #, c-format | ||
| msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n" | ||
| msgstr "" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
New error messages need translation
New error messages have been added for unaligned memory access in LWC2/SWC2 instructions. These messages need to be translated in all localization files:
msgid "Unaligned address 0x%08x in LWC2 from 0x%08x\n"
msgid "Unaligned address 0x%08x in SWC2 from 0x%08x\n"
| #: src/gpu/soft/gpu.cc:261 | ||
| msgid "Disable textures for polygons" | ||
| msgstr "" | ||
|
|
||
| #: src/gpu/soft/gpu.cc:262 | ||
| msgid "Disable textures for sprites" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
New texture control messages need translation
New UI messages have been added for texture control options:
msgid "Disable textures for polygons"
msgid "Disable textures for sprites"
| #: src/gui/widgets/patches.cc:35 | ||
| msgid "Patching is only available in Interpreted CPU mode" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:68 | ||
| msgid "Delete Patch?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:69 | ||
| msgid "Delete" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "NOP" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:88 | ||
| msgid "Return" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:96 | ||
| msgid "Activate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:101 | ||
| msgid "Deactivate All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:107 | ||
| msgid "Delete All" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:111 | ||
| msgid "Delete all Patches?" | ||
| msgstr "" | ||
|
|
||
| #: src/gui/widgets/patches.cc:112 | ||
| msgid "Delete##patches" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
New patch management UI needs translation
Several new strings have been added for patch management functionality:
msgid "Patching is only available in Interpreted CPU mode"
msgid "Delete Patch?"
msgid "Delete"
msgid "NOP"
msgid "Return"
msgid "Activate All"
msgid "Deactivate All"
msgid "Delete All"
msgid "Delete all Patches?"
msgid "Delete##patches"
| msgid "Draw Area End" | ||
| msgstr "" | ||
|
|
||
| #: src/core/gpulogger.cc:421 | ||
| #: src/core/gpulogger.cc:429 |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Fix inconsistent translations.
The following translations need correction:
- "Draw Offset" should be "Décalage de dessin" instead of "Fichiers"
- "Unknown" should be "Inconnu" instead of "Ignorer les inconnus"
msgid "Draw Offset"
-msgstr "Fichiers"
+msgstr "Décalage de dessin"
msgid "Unknown"
-msgstr "Ignorer les inconnus"
+msgstr "Inconnu"Also applies to: 401-401
Automated changes by create-pull-request GitHub action