Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support.extra dofile & friends #1478

Merged
merged 8 commits into from
Dec 9, 2023

Conversation

nicolasnoble
Copy link
Member

  • able to locate files nearby previously loaded files
  • able to locate files inside .zip files

@ghost
Copy link

ghost commented Dec 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

- able to locate files nearby previously loaded files
- able to locate files inside .zip files
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (3db2564) 8.67% compared to head (533a2b9) 8.67%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/lua/extra.cc 12.79% 75 Missing ⚠️
src/gui/gui.cc 0.00% 33 Missing ⚠️
src/main/main.cc 35.71% 9 Missing ⚠️
src/lua/luawrapper.h 0.00% 6 Missing ⚠️
src/support/zip.cc 0.00% 5 Missing ⚠️
src/support/zip.h 0.00% 3 Missing ⚠️
src/support/version-linux.cc 0.00% 2 Missing ⚠️
src/gui/gui.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1478    +/-   ##
========================================
  Coverage    8.67%    8.67%            
========================================
  Files         413      413            
  Lines      125907   126037   +130     
========================================
+ Hits        10923    10939    +16     
- Misses     114984   115098   +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit bd3b657 into grumpycoders:main Dec 9, 2023
16 of 17 checks passed
@nicolasnoble nicolasnoble deleted the lua-dofile branch December 9, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant