Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring / fixing / documenting ps1-packer. #1464

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

nicolasnoble
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Nov 16, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (a072e38) 8.59% compared to head (85eea1e) 8.67%.
Report is 68 commits behind head on main.

Files Patch % Lines
src/supportpsx/ps1-packer.cc 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
+ Coverage    8.59%    8.67%   +0.07%     
==========================================
  Files         408      413       +5     
  Lines      125609   126165     +556     
==========================================
+ Hits        10802    10944     +142     
- Misses     114807   115221     +414     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit 5419e2d into grumpycoders:main Dec 13, 2023
16 of 17 checks passed
@nicolasnoble nicolasnoble deleted the ps1-packer-refactor branch December 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant