Adding nopad option to ps1-packer. #1463
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Nov 14, 2023 in 45s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 3 findings(s) 🚩
- Improving Code Health: 0 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method ps1-packer.cc: PCSX::PS1Packer::pack
- Complex Conditional ps1-packer.cc: PCSX::PS1Packer::pack
- Complex Method ps1-packer.cc: main
Annotations
Check warning on line 175 in src/supportpsx/ps1-packer.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PCSX::PS1Packer::pack increases in cyclomatic complexity from 35 to 36, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 175 in src/supportpsx/ps1-packer.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Conditional
PCSX::PS1Packer::pack increases from 1 complex conditionals with 4 branches to 1 complex conditionals with 5 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 104 in tools/ps1-packer/ps1-packer.cc
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
main already has high cyclomatic complexity, and now it increases in Lines of Code from 81 to 84. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading