Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InputText and InputTextWithHint to Lua. #1453

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

nicolasnoble
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Oct 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (79d6157) 8.61% compared to head (4d7a494) 8.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage    8.61%    8.61%   -0.01%     
==========================================
  Files         409      409              
  Lines      125567   125622      +55     
==========================================
  Hits        10823    10823              
- Misses     114744   114799      +55     
Files Coverage Δ
src/gui/luaimguiextra.cc 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit 755ec00 into grumpycoders:main Oct 7, 2023
15 of 17 checks passed
@nicolasnoble nicolasnoble deleted the imgui-lua-inputtext branch October 7, 2023 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant