Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting to yeet the template files out of the vsce. #1442

Merged
merged 13 commits into from
Dec 31, 2023

Conversation

nicolasnoble
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Sep 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Attention: 758 lines in your changes are missing coverage. Please review.

Comparison is base (4a9a8eb) 8.63% compared to head (f2a316c) 8.75%.
Report is 220 commits behind head on main.

Files Patch % Lines
src/gui/widgets/registers.cc 0.00% 153 Missing ⚠️
src/core/web-server.cc 2.77% 105 Missing ⚠️
src/gui/widgets/named_savestates.cc 0.00% 100 Missing ⚠️
src/lua/extra.cc 12.79% 75 Missing ⚠️
src/gui/gui.cc 0.00% 71 Missing ⚠️
src/gui/luaimguiextra.cc 0.00% 57 Missing ⚠️
src/supportpsx/ps1-packer.cc 0.00% 41 Missing ⚠️
src/core/pad.cc 42.18% 37 Missing ⚠️
third_party/imgui_lua_bindings/imgui_iterator.inl 0.00% 25 Missing ⚠️
src/core/r3000a.cc 53.84% 12 Missing ⚠️
... and 25 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1442      +/-   ##
==========================================
+ Coverage    8.63%    8.75%   +0.12%     
==========================================
  Files         409      413       +4     
  Lines      125568   126143     +575     
==========================================
+ Hits        10842    11046     +204     
- Misses     114726   115097     +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolasnoble nicolasnoble merged commit 6acfae2 into grumpycoders:main Dec 31, 2023
16 of 17 checks passed
@nicolasnoble nicolasnoble deleted the vsce-yeet branch December 31, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant