Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] rename android platforms to match CPU arch #36715

Closed
wants to merge 2 commits into from

Conversation

jdcormie
Copy link
Member

Work around for bazelbuild/bazel#15837 (comment)

Fixes a problem where the example client and server APKs would build but could not be installed (INSTALL_FAILED_NO_MATCHING_ABIS: Failed to extract native libraries)

@sifmelcara
Copy link
Member

Thanks!

  1. I think we should move these platform declaration to subfolder if we want to remove android_ prefix, maybe bazel/platforms/android/BUILD. (In google's internal repo we declare them at //.../platforms/android/BUILD)
  2. Change PR and commit message title to [build] Rename android platforms to match CPU arch

@sifmelcara sifmelcara added kokoro:run release notes: no Indicates if PR should not be in release notes labels May 24, 2024
@jdcormie jdcormie changed the title rename android platforms to match CPU arch [build] rename android platforms to match CPU arch May 24, 2024
@jdcormie jdcormie closed this May 24, 2024
@jdcormie
Copy link
Member Author

Thanks!

  1. I think we should move these platform declaration to subfolder if we want to remove android_ prefix, maybe bazel/platforms/android/BUILD. (In google's internal repo we declare them at //.../platforms/android/BUILD)
  2. Change PR and commit message title to [build] Rename android platforms to match CPU arch

done

@sifmelcara sifmelcara requested review from sifmelcara and veblush and removed request for drfloob, gnossen, veblush, apolcyn and ctiller May 24, 2024 21:46
Copy link
Member

@sifmelcara sifmelcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are still failing after rerun, but the failure doesn't look like relating to this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants