Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmark] Disable benchmarks for dotnet in CI. #36699

Closed
wants to merge 5 commits into from

Conversation

paulosjca
Copy link
Contributor

Build is failing, so temporarily removing dotnet from benchmarks CI.

Build is failing, so temporarily removing dotnet from benchmarks CI.
tanvi-jagtap and others added 4 commits May 23, 2024 16:41
…log (grpc#36678)

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping

1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :

1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

Closes grpc#36678

COPYBARA_INTEGRATE_REVIEW=grpc#36678 from tanvi-jagtap:test_cpp_gpr_log 81b8f41
PiperOrigin-RevId: 636410944
Fixed various MSAN and UBSAN issues found in an attempt to bump the clang version used for RBE. (grpc#36685) As our xSAN tests are using RBE, it revealed a few new issues. This PR is to fix all of those.

Closes grpc#36707

COPYBARA_INTEGRATE_REVIEW=grpc#36707 from veblush:fix-xsan ebbebc2
PiperOrigin-RevId: 636685138
Closes grpc#36597

COPYBARA_INTEGRATE_REVIEW=grpc#36597 from markdroth:transport_endpoint_cleanup 6bd73e4
PiperOrigin-RevId: 636714985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants