Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc-js): Add support for typed add service #1561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slavovojacek
Copy link
Contributor

@murgatroid99
Copy link
Member

The problem with the previous change was that it did not properly handle service definition objects that were typed as simply

interface ServiceDefinition {
  [key: string]: MethodDefinition
}

along with implementation objects with types that specified the individual member names. I'm not sure if this change addresses that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants