Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: introduce simple grpc transport for generic xds clients #8066

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+447 −0

easwar review 3

5050360
Select commit
Loading
Failed to load commit list.
Open

xds: introduce simple grpc transport for generic xds clients #8066

easwar review 3
5050360
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2025 in 0s

82.48% (+0.25%) compared to c7db760

View this Pull Request on Codecov

82.48% (+0.25%) compared to c7db760

Details

Codecov Report

Attention: Patch coverage is 84.90566% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (c7db760) to head (5050360).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...s/internal/clients/grpctransport/grpc_transport.go 84.90% 6 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8066      +/-   ##
==========================================
+ Coverage   82.23%   82.48%   +0.25%     
==========================================
  Files         387      388       +1     
  Lines       38947    38995      +48     
==========================================
+ Hits        32028    32165     +137     
+ Misses       5601     5532      -69     
+ Partials     1318     1298      -20
Files with missing lines Coverage Δ
...s/internal/clients/grpctransport/grpc_transport.go 84.90% <84.90%> (ø)

... and 30 files with indirect coverage changes

View more details on Codecov