Update copy on experiment without results #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin-Chant
commented
May 8, 2024
|
Your preview environment pr-2498-bttf has been deployed. |
bryce-fitzsimons
requested changes
May 9, 2024
Change text when experiment hasn't started yet #318
Kevin-Chant
force-pushed
the
kc/future-experiment-copy
branch
from
4462dbb
to
50382a6
Compare
bryce-fitzsimons
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Change text when experiment hasn't started yet to fix awkward copy
Also added a new helper to the shared dates utils to grab the relative date compared to now, as
agodoesn't work well for future dates.Dependencies
None
Testing
Open a sample experiment and edit the main phase to start at a future date
Also verify that using a timestamp in the last 2 hours still triggers the existing copy
And check that setting the phase to start > 2 hours ago allows results to show again
Screenshots
Existing copy still applies:
Examples of copy with future dates:
Experiment results are not hidden when the phase properly starts in the past:
