Skip to content

Commit

Permalink
Fixed missing argument in method
Browse files Browse the repository at this point in the history
  • Loading branch information
grodansparadis committed Nov 22, 2024
1 parent bcfae7d commit efadc63
Show file tree
Hide file tree
Showing 10 changed files with 34 additions and 30 deletions.
4 changes: 2 additions & 2 deletions src/vscp/common/mdf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9744,11 +9744,11 @@ CMDF::deleteEvent(CMDF_Event *pEvent)
}

///////////////////////////////////////////////////////////////////////////////
// createRegisterStortedSet
// createRegisterSortedSet
//

void
CMDF::createRegisterStortedSet(std::set<uint32_t> &set, uint16_t page)
CMDF::createRegisterSortedSet(std::set<uint32_t> &set, uint16_t page)
{
std::deque<CMDF_Register *> *regset = getRegisterObjList();
for (auto it = regset->cbegin(); it != regset->cend(); ++it) {
Expand Down
2 changes: 1 addition & 1 deletion src/vscp/common/mdf.h
Original file line number Diff line number Diff line change
Expand Up @@ -3911,7 +3911,7 @@ class CMDF : public CMDF_Object {
Create a set with sorted register offsets for a page
@param set a std_set with offset uint32_t items
*/
void createRegisterStortedSet(std::set<uint32_t> &set, uint16_t page);
void createRegisterSortedSet(std::set<uint32_t> &set, uint16_t page);

/*!
Get all registers for a specific page
Expand Down
10 changes: 5 additions & 5 deletions src/vscp/common/vscp-bootdevice-vscp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ CBootDevice_VSCP::deviceInit(cguid &ourguid, uint8_t devicecode, bool bAbortOnFi
if (VSCP_ERROR_SUCCESS !=
(rv = checkResponse(ex, node_guid, VSCP_TYPE_PROTOCOL_ACK_BOOT_LOADER, VSCP_TYPE_PROTOCOL_NACK_BOOT_LOADER))) {
// Negative response on bootmode request- return
spdlog::debug("VSCP bootloader: NACK recived from set bootloader request.");
spdlog::debug("VSCP bootloader: NACK received from set bootloader request.");
if (nullptr != m_statusCallback) {
m_statusCallback(-1, "VSCP bootloader: NACK received from set bootloader request.");
}
Expand Down Expand Up @@ -688,9 +688,9 @@ CBootDevice_VSCP::checkResponse(vscpEventEx &ex,
// Is this a read/write reply from the node?
if ((VSCP_CLASS1_PROTOCOL == ex.vscp_class) && (response_event_ack == ex.vscp_type) && guid.isSameGUID(ex.GUID)) {
// ACK response
spdlog::debug("VSCP Bootloader: ACK recived.");
spdlog::debug("VSCP Bootloader: ACK received.");
if (nullptr != m_statusCallback) {
m_statusCallback(-1, "VSCP Bootloader:ACK recived");
m_statusCallback(-1, "VSCP Bootloader:ACK received");
}
rv = VSCP_ERROR_SUCCESS;
break;
Expand All @@ -700,9 +700,9 @@ CBootDevice_VSCP::checkResponse(vscpEventEx &ex,
if ((VSCP_CLASS1_PROTOCOL == ex.vscp_class) && (response_event_nack == ex.vscp_type) &&
guid.isSameGUID(ex.GUID)) {
// NACK response
spdlog::debug("VSCP Bootloader: NACK recived.");
spdlog::debug("VSCP Bootloader: NACK received.");
if (nullptr != m_statusCallback) {
m_statusCallback(-1, "VSCP Bootloader: NACK recived.");
m_statusCallback(-1, "VSCP Bootloader: NACK received.");
}
rv = VSCP_ERROR_NACK;
break;
Expand Down
32 changes: 18 additions & 14 deletions src/vscp/common/vscp-bootdevice-vscp.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@

#include "vscp.h"

#include <string>

// This macro construct a signed integer from two unsigned chars in a safe way
#define construct_signed16(msb, lsb) ((int16_t) ((((uint16_t) msb) << 8) + (uint16_t) lsb))
Expand All @@ -52,9 +51,11 @@ class CBootDevice_VSCP : public CBootDevice {
/*!
Constructor
@param pdll Pointer to opended CANAL object.
@param pclient Pointer to active client object.
@param nodeid Nickname/nodeid for node that should be loaded
with new code.
with new code.
@param statusCallback Status callback function or NULL
@param timeout Timeout for response
*/
CBootDevice_VSCP(CVscpClient *pclient,
uint8_t nodeid,
Expand All @@ -67,10 +68,11 @@ class CBootDevice_VSCP : public CBootDevice {
This is Level I over Level II that uses an interface on
a remote device to communicate with Level I nodes.
@param pdll Pointer to opended CANAL object.
@param pclient Pointer to active client object.
@param nodeid Nickname/nodeid for node that should be loaded
@param guidif GUID for interface.
with new code.
@param statusCallback Status callback function or NULL
@param timeout Timeout for response
*/
CBootDevice_VSCP(CVscpClient *pclient,
uint8_t nodeid,
Expand All @@ -83,8 +85,10 @@ class CBootDevice_VSCP : public CBootDevice {
This is a full level II device. No interface, full GUID.
@param ptcpip Pointer to opened TCP/IP interface object.
@param pclient Pointer to active client object.
@param guid GUID for node to bootload.
@param statusCallback Status callback function or NULL
@param timeout Timeout for response
*/
CBootDevice_VSCP(CVscpClient *pclient,
cguid &guid,
Expand Down Expand Up @@ -186,13 +190,13 @@ class CBootDevice_VSCP : public CBootDevice {

/*!
Restart remote device
@return VSCP_ERROR_SUCCESS is returned on success, ortherwise error code
@return VSCP_ERROR_SUCCESS is returned on success, otherwise error code
*/
int deviceRestart(void);

/*!
Reboot remote device
@return VSCP_ERROR_SUCCESS is returned on success, ortherwise error code
@return VSCP_ERROR_SUCCESS is returned on success, otherwise error code
*/
int deviceReboot(void);

Expand All @@ -201,7 +205,7 @@ class CBootDevice_VSCP : public CBootDevice {
/*!
Write block start to remote device
@param block Block number to write
@param type Memoty type code for memory to write
@param type Memory type code for memory to write
@return VSCP_ERROR_SUCCESS on success.
*/
int writeBlockStart(uint32_t block, uint8_t type);
Expand All @@ -215,7 +219,7 @@ class CBootDevice_VSCP : public CBootDevice {

/*!
Write a sector
@param paddr Pointer to firts byte of 8-byte block to write
@param paddr Pointer to first byte of 8-byte block to write
to remote device
@param size Number of data bytes to send. Must be less than the
max event data (8/512)
Expand All @@ -236,8 +240,8 @@ class CBootDevice_VSCP : public CBootDevice {
@param guid GUID for our device the expected event should originate from.
@param response_event_ack ACK event type.
@param response_event_nack NACK event type.
@return VSCP_ERROR_SUCCESS if ack is received within the timoeut time. VSCP_ERROR_NACK if NACK
event is received. VSCP_ERROR_TIMEOUT if timeout occured.
@return VSCP_ERROR_SUCCESS if ack is received within the timeout time. VSCP_ERROR_NACK if NACK
event is received. VSCP_ERROR_TIMEOUT if timeout occurred.
*/
int checkResponse(vscpEventEx &ex,
cguid &guid,
Expand Down Expand Up @@ -277,7 +281,7 @@ class CBootDevice_VSCP : public CBootDevice {
it holds 8/512 bytes. It's up to the remote device to handle both
cases.
block size can be less then chunk size. This is escpecially true
block size can be less then chunk size. This is especially true
for level II
*/
uint16_t m_chunkSize;
Expand All @@ -286,7 +290,7 @@ class CBootDevice_VSCP : public CBootDevice {
Block size in bytes
-------------------
This is the block size the remote device expect us to send before
programing a block.
programming a block.
Programming is done in chunks of 8 or 512 bytes or less until a full
block has been written.
*/
Expand Down
6 changes: 3 additions & 3 deletions src/vscp/common/vscp-bootdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class CBootDevice {
@param pmin Pointer to variable that will get min address
@param pmax Pointer to variable that will get max address
@return VSCP_ERROR_SUCCESS on success.
VSCP_ERROR_INVALID_POINTER if ponters are invalid.
VSCP_ERROR_INVALID_POINTER if pointers are invalid.
VSCP_ERROR_INVALID_PARAMETER if end <= start
VSCP_ERROR_ERROR if no memory defined in the selected range. value of
pmin/pmax is zero in this case.
Expand Down Expand Up @@ -243,7 +243,7 @@ class CBootDevice {
and status message (const char *)
@return VSCP_ERROR_SUCCESS on success.
*/
virtual int deviceLoad(std::function<void(int, const char *)> statusCallback = nullptr) = 0;
virtual int deviceLoad(std::function<void(int, const char *)> statusCallback = nullptr, bool bAbortOnFirmwareCodeFail = false) = 0;

/*!
Restart the device
Expand All @@ -258,7 +258,7 @@ class CBootDevice {
CVscpClient *m_pclient;

/*!
Tomeout for read operations
Timeout for read operations
*/
uint32_t m_timeout;

Expand Down
2 changes: 1 addition & 1 deletion third_party/maddy
Submodule maddy updated 56 files
+46 −0 .clang-format
+4 −1 .editorconfig
+11 −0 .github/dependabot.yml
+1 −1 .github/workflows/create-release-package.yml
+25 −0 .github/workflows/run-checks.yml
+4 −7 .github/workflows/run-tests.yml
+54 −0 .github/workflows/update-dependencies.yml
+3 −1 CHANGELOG.md
+29 −40 include/maddy/blockparser.h
+2 −3 include/maddy/breaklineparser.h
+15 −28 include/maddy/checklistparser.h
+11 −23 include/maddy/codeblockparser.h
+5 −4 include/maddy/emphasizedparser.h
+22 −31 include/maddy/headlineparser.h
+10 −22 include/maddy/horizontallineparser.h
+10 −25 include/maddy/htmlparser.h
+2 −3 include/maddy/imageparser.h
+2 −3 include/maddy/inlinecodeparser.h
+5 −4 include/maddy/italicparser.h
+13 −24 include/maddy/latexblockparser.h
+2 −3 include/maddy/linkparser.h
+14 −30 include/maddy/orderedlistparser.h
+10 −25 include/maddy/paragraphparser.h
+96 −180 include/maddy/parser.h
+6 −4 include/maddy/parserconfig.h
+11 −24 include/maddy/quoteparser.h
+5 −4 include/maddy/strikethroughparser.h
+9 −7 include/maddy/strongparser.h
+12 −25 include/maddy/tableparser.h
+13 −28 include/maddy/unorderedlistparser.h
+1 −1 tests/CMakeLists.txt
+20 −19 tests/maddy/test_maddy_checklistparser.cpp
+8 −16 tests/maddy/test_maddy_codeblockparser.cpp
+2 −1 tests/maddy/test_maddy_emphasizedparser.cpp
+12 −19 tests/maddy/test_maddy_headlineparser.cpp
+6 −7 tests/maddy/test_maddy_horizontallineparser.cpp
+14 −21 tests/maddy/test_maddy_htmlparser.cpp
+8 −3 tests/maddy/test_maddy_imageparser.cpp
+2 −1 tests/maddy/test_maddy_inlinecodeparser.cpp
+0 −1 tests/maddy/test_maddy_italicparser.cpp
+5 −12 tests/maddy/test_maddy_latexblockparser.cpp
+10 −4 tests/maddy/test_maddy_linkparser.cpp
+16 −25 tests/maddy/test_maddy_orderedlistparser.cpp
+4 −12 tests/maddy/test_maddy_paragraphparser.cpp
+6 −4 tests/maddy/test_maddy_parser.cpp
+70 −4 tests/maddy/test_maddy_parser.h
+6 −14 tests/maddy/test_maddy_quoteparser.cpp
+4 −2 tests/maddy/test_maddy_strikethroughparser.cpp
+13 −26 tests/maddy/test_maddy_strongparser.cpp
+19 −16 tests/maddy/test_maddy_tableparser.cpp
+16 −25 tests/maddy/test_maddy_unorderedlistparser.cpp
+2 −1 tests/main.cpp
+12 −0 tools/Pipfile
+165 −0 tools/Pipfile.lock
+143 −0 tools/format.py
+155 −0 tools/update_dependencies.py
2 changes: 1 addition & 1 deletion third_party/mongoose
Submodule mongoose updated 1444 files
2 changes: 1 addition & 1 deletion third_party/nlohmann
Submodule nlohmann updated 60 files
+10 −0 .clang-tidy
+1 −1 .github/CONTRIBUTING.md
+3 −3 .github/workflows/check_amalgamation.yml
+1 −1 .github/workflows/cifuzz.yml
+2 −2 .github/workflows/codeql-analysis.yml
+61 −9 .github/workflows/macos.yml
+2 −2 .github/workflows/publish_documentation.yml
+48 −27 .github/workflows/ubuntu.yml
+7 −7 .github/workflows/windows.yml
+0 −1 BUILD.bazel
+11 −2 CMakeLists.txt
+52 −38 README.md
+15 −4 cmake/ci.cmake
+1 −1 docs/mkdocs/docs/api/basic_json/is_structured.md
+1 −1 docs/mkdocs/docs/api/basic_json/operator_gt.md
+1 −1 docs/mkdocs/docs/api/basic_json/operator_le.md
+1 −1 docs/mkdocs/docs/api/basic_json/operator_lt.md
+118 −0 docs/mkdocs/docs/api/macros/nlohmann_define_derived_type.md
+22 −0 include/nlohmann/detail/conversions/from_json.hpp
+7 −7 include/nlohmann/detail/conversions/to_chars.hpp
+19 −0 include/nlohmann/detail/conversions/to_json.hpp
+16 −0 include/nlohmann/detail/exceptions.hpp
+9 −0 include/nlohmann/detail/input/input_adapters.hpp
+2 −2 include/nlohmann/detail/input/json_sax.hpp
+3 −3 include/nlohmann/detail/input/lexer.hpp
+2 −2 include/nlohmann/detail/input/parser.hpp
+2 −2 include/nlohmann/detail/iterators/iteration_proxy.hpp
+30 −0 include/nlohmann/detail/macro_scope.hpp
+1 −1 include/nlohmann/detail/meta/cpp_future.hpp
+1 −1 include/nlohmann/detail/meta/std_fs.hpp
+3 −3 include/nlohmann/detail/meta/type_traits.hpp
+1 −1 include/nlohmann/detail/output/binary_writer.hpp
+3 −3 include/nlohmann/detail/output/serializer.hpp
+19 −19 include/nlohmann/json.hpp
+129 −129 nlohmann_json.natvis
+141 −44 single_include/nlohmann/json.hpp
+1 −1 tests/src/unit-32bit.cpp
+2 −2 tests/src/unit-alt-string.cpp
+5 −5 tests/src/unit-bjdata.cpp
+1 −1 tests/src/unit-bson.cpp
+5 −6 tests/src/unit-cbor.cpp
+1 −1 tests/src/unit-class_lexer.cpp
+0 −1 tests/src/unit-concepts.cpp
+99 −2 tests/src/unit-conversions.cpp
+17 −13 tests/src/unit-deserialization.cpp
+14 −14 tests/src/unit-element_access1.cpp
+10 −10 tests/src/unit-element_access2.cpp
+1 −1 tests/src/unit-json_patch.cpp
+3 −3 tests/src/unit-msgpack.cpp
+13 −4 tests/src/unit-noexcept.cpp
+1 −1 tests/src/unit-readme.cpp
+7 −0 tests/src/unit-regression1.cpp
+65 −6 tests/src/unit-regression2.cpp
+1 −1 tests/src/unit-serialization.cpp
+2 −2 tests/src/unit-testsuites.cpp
+2 −2 tests/src/unit-ubjson.cpp
+28 −1 tests/src/unit-udt.cpp
+189 −4 tests/src/unit-udt_macro.cpp
+1 −1 tests/src/unit-unicode1.cpp
+13 −13 tools/generate_natvis/nlohmann_json.natvis.j2
2 changes: 1 addition & 1 deletion third_party/spdlog
Submodule spdlog updated 46 files
+26 −18 .github/workflows/linux.yml
+28 −0 .github/workflows/macos.yml
+148 −0 .github/workflows/windows.yml
+33 −6 CMakeLists.txt
+11 −4 README.md
+1 −1 bench/async_bench.cpp
+2 −2 bench/bench.cpp
+13 −2 cmake/utils.cmake
+11 −4 example/example.cpp
+5 −7 include/spdlog/async_logger-inl.h
+3 −3 include/spdlog/details/mpmc_blocking_q.h
+3 −3 include/spdlog/details/os-inl.h
+3 −8 include/spdlog/details/thread_pool-inl.h
+3 −14 include/spdlog/details/thread_pool.h
+54 −61 include/spdlog/fmt/bundled/args.h
+3,077 −0 include/spdlog/fmt/bundled/base.h
+335 −143 include/spdlog/fmt/bundled/chrono.h
+81 −112 include/spdlog/fmt/bundled/color.h
+52 −58 include/spdlog/fmt/bundled/compile.h
+4 −2,968 include/spdlog/fmt/bundled/core.h
+277 −27 include/spdlog/fmt/bundled/format-inl.h
+624 −732 include/spdlog/fmt/bundled/format.h
+86 −102 include/spdlog/fmt/bundled/os.h
+25 −59 include/spdlog/fmt/bundled/ostream.h
+117 −136 include/spdlog/fmt/bundled/printf.h
+314 −170 include/spdlog/fmt/bundled/ranges.h
+278 −116 include/spdlog/fmt/bundled/std.h
+109 −46 include/spdlog/fmt/bundled/xchar.h
+4 −0 include/spdlog/mdc.h
+16 −2 include/spdlog/pattern_formatter-inl.h
+1 −1 include/spdlog/sinks/ansicolor_sink.h
+4 −4 include/spdlog/sinks/base_sink.h
+1 −1 include/spdlog/sinks/callback_sink.h
+2 −0 include/spdlog/sinks/daily_file_sink.h
+2 −0 include/spdlog/sinks/hourly_file_sink.h
+1 −1 include/spdlog/sinks/msvc_sink.h
+1 −1 include/spdlog/sinks/rotating_file_sink-inl.h
+3 −2 include/spdlog/sinks/syslog_sink.h
+9 −0 include/spdlog/sinks/wincolor_sink-inl.h
+2 −2 include/spdlog/version.h
+12 −10 src/bundled_fmtlib_format.cpp
+4 −2 tests/CMakeLists.txt
+6 −1 tests/includes.h
+0 −44 tests/test_async.cpp
+20 −2 tests/test_misc.cpp
+2 −0 tests/test_pattern_formatter.cpp
2 changes: 1 addition & 1 deletion third_party/tiny-aes

0 comments on commit efadc63

Please sign in to comment.