Firmware code initialized to zero (was uninitialized)

grodansparadis · Nov 22, 2024 · add3abb · add3abb
1 parent dbdc188
commit add3abb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/vscp/common/vscp-bootdevice-pic1.cpp b/src/vscp/common/vscp-bootdevice-pic1.cpp
@@ -342,7 +342,7 @@ CBootDevice_PIC1::deviceInit(cguid& ourguid, uint16_t devicecode, bool bAbortOnF
     Must be the same as the firmware we try to load is intended for
   */
   if (m_firmwaredeviceCode != m_stdRegs.getFirmwareDeviceCode()) {
-    spdlog::warn("Firware device code is not equal the one on the device local: {0} device: {1}",
+    spdlog::warn("Firmware device code is not equal the one on the device local: {0} device: {1}",
                  m_firmwaredeviceCode,
                  m_stdRegs.getFirmwareDeviceCode());
     if (nullptr != m_statusCallback) {

diff --git a/src/vscp/common/vscp-bootdevice-vscp.cpp b/src/vscp/common/vscp-bootdevice-vscp.cpp
@@ -239,7 +239,7 @@ CBootDevice_VSCP::deviceInit(cguid &ourguid, uint16_t devicecode, bool bAbortOnF
     Must be the same as the firmware we try to load is intended for
   */
   if (m_firmwaredeviceCode != m_stdRegs.getFirmwareDeviceCode()) {
-    spdlog::warn("Firmware device code is not equal the one on the device local: {0} device: {1}",
+    spdlog::warn("Firmware device code is not equal! Firmware: {0} Device: {1}",
                  m_firmwaredeviceCode,
                  m_stdRegs.getFirmwareDeviceCode());
     if (nullptr != m_statusCallback) {

diff --git a/src/vscp/common/vscp-bootdevice.cpp b/src/vscp/common/vscp-bootdevice.cpp
@@ -107,6 +107,7 @@ CBootDevice::CBootDevice(CVscpClient *pclient,
   m_timeout        = timeout;
   m_statusCallback = statusCallback;
   m_startAddr      = 0; // Boot start
+  m_firmwaredeviceCode = 0;
 }
 
 CBootDevice::CBootDevice(CVscpClient *pclient,