Added error loging

grodansparadis · May 12, 2020 · 1e71cde · 1e71cde
1 parent ae7c96f
commit 1e71cde
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/vscp/common/devicethread.cpp b/src/vscp/common/devicethread.cpp
@@ -945,11 +945,20 @@ deviceLevel1WriteThread(void* pData)
             }
 
             canalMsg msg;
-            vscp_convertEventToCanal(&msg, pev);
+            if (!vscp_convertEventToCanal(&msg, pev)) {
+                syslog(
+                  LOG_ERR,
+                  "deviceLevel1WriteThread - vscp_convertEventToCanal failed");
+                vscp_deleteEvent(pev);
+            }
+
             if (CANAL_ERROR_SUCCESS ==
                 pDevItem->m_proc_CanalBlockingSend(pDevItem->m_openHandle,
                                                    &msg,
                                                    300)) {
+                syslog(
+                  LOG_ERR,
+                  "deviceLevel1WriteThread - m_proc_CanalBlockingSend failed");
                 vscp_deleteEvent(pev);
             }
             else {

diff --git a/src/vscp/common/vscphelper.cpp b/src/vscp/common/vscphelper.cpp
@@ -4927,10 +4927,13 @@ vscp_convertEventToCanal(canalMsg* pcanalMsg, const vscpEvent* pvscpEvent)
     short sizeData       = 0;
     uint16_t vscp_class  = 0;
 
-    if (NULL == pcanalMsg)
+    if (NULL == pcanalMsg) {
         return false;
-    if (NULL == pvscpEvent)
+    }
+
+    if (NULL == pvscpEvent) {
         return false;
+    }
 
     sizeData   = pvscpEvent->sizeData;
     vscp_class = pvscpEvent->vscp_class;