fix(resize): update the grid to resize when initialised in the smaller screen #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GowthamTG
changed the title
adumesny
reviewed
Feb 17, 2025
| @@ -346,8 +346,6 @@ export class GridStack { | |||
| opts = Utils.defaults(opts, defaults); | |||
| this._initMargin(); // part of settings defaults... | |||
|
|
|||
| // Now check if we're loading into 1 column mode FIRST so we don't do un-necessary work (like cellHeight = width / 12 then go 1 column) | |||
| this.checkDynamicColumn(); | |||
There was a problem hiding this comment.
this removes optimizations so this isn't the right fix even if it fixes the issue...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change would help recalculate the grid-layout when it is getting initialised in the smaller screen
#2947
Screen.Recording.Feb.17.2025.1.mov
Checklist
yarn test)