Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipping initial pipeline call when search keyword is present #1331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

skipping initial pipeline call when search keyword is present #1331

wants to merge 1 commit into from

Conversation

mnsrulz
Copy link

@mnsrulz mnsrulz commented Mar 8, 2023

Addressing #1330

@mnsrulz
Copy link
Author

mnsrulz commented Mar 8, 2023

Fix #1330

@PinticanFlavius
Copy link

when this fix will be merged?

afshinm
afshinm reviewed Mar 3, 2024
View reviewed changes
src/view/container.tsx
if ((config.search as SearchConfig)?.keyword) {
//skipping initial pipeline as search keyword is present and search plugin will handle the initial data laod
} else {
processPipeline();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to skip this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look into the referenced issue #1330 that has more details to it. I see that you pushed fixes related to that already. I didn't get a chance to validate the new build, but if #1330 is already fixed in your other fixes then we don't need this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afshinm afshinm afshinm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnsrulz @PinticanFlavius @afshinm