Support PostgreSQL INCLUDE indexes in ExtraneousIndexes checker
#133
+59
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
include-indexes
branch
from
21e3e92
to
de58765
Compare
gregnavis
force-pushed
the
master
branch
2 times, most recently
from
168d951
to
d322a6e
Compare
gregnavis
previously approved these changes
Jun 7, 2024
fatkodima
force-pushed
the
include-indexes
branch
from
de58765
to
98b71c2
Compare
|
Rebased. |
gregnavis
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 will have support for PostgreSQL
INCLUDEindexes - rails/rails#44803. If you are ok with this PR changes, we can wait when the new rails version is released or can merge earlier, since some people are running on some sort of rails head and will already benefit from this.This gem's CI is not testing against rails head, so the newly added tests are skipped currently.