Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use vexflow to render note name #8

Merged
merged 2 commits into from Apr 1, 2023
Merged

Conversation

gregjopa
Copy link
Owner

Screen Shot 2023-03-29 at 10 37 17 PM

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.84 ⚠️

Comparison is base (898e3d7) 68.40% compared to head (f7be23b) 67.56%.

❗ Current head f7be23b differs from pull request most recent head aa17989. Consider uploading reports for the commit aa17989 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   68.40%   67.56%   -0.84%     
==========================================
  Files          13       13              
  Lines         326      333       +7     
  Branches       61       64       +3     
==========================================
+ Hits          223      225       +2     
- Misses        103      108       +5     
Impacted Files Coverage Δ
src/components/StaveNote.tsx 0.00% <0.00%> (ø)
src/App.tsx 93.24% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gregjopa gregjopa merged commit 1226a1f into main Apr 1, 2023
1 check passed
@gregjopa gregjopa deleted the note-name-vexflow branch April 1, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant