Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Do not truncate operating system names #1061

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Fix: Do not truncate operating system names #1061

merged 1 commit into from
Nov 13, 2023

Conversation

4D617274696E
Copy link
Contributor

What

  • Fixed the logic for setting names of generated operating systems.

Why

Names for generated operating systems were being cut off after the first letter.

Checklist

  • Tests
  • Checked with pylint.
  • Tested manually by comparing generated reports from before and after the fix.
    • Test environment: gvm-cli 23.10.0 (API version 23.10.1) & GOS 22.04.15

@4D617274696E
Fix: Do not truncate operating system names
c3ef0c1 
Fixed names for generated operating systems being cut off after the first letter.
@4D617274696E 4D617274696E requested a review from a team as a code owner November 13, 2023 14:20
@greenbonebot greenbonebot enabled auto-merge (rebase) November 13, 2023 14:20
@github-actions GitHub Actions
Copy link

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@greenbonebot greenbonebot merged commit 67d90a1 into greenbone:main Nov 13, 2023
19 checks passed
@4D617274696E 4D617274696E deleted the fix-os-names branch November 14, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernricks bjoernricks bjoernricks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4D617274696E @bjoernricks @greenbonebot