Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application detection #1048

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix application detection #1048

merged 2 commits into from
Sep 28, 2023

Conversation

timopollmeier
Copy link
Member

What

The script application-detection.gmp.py will now get the report
details and extract the host IP addresses correctly.

The application-detection script now requests details for each report
individually with minimum results, which is usually faster for gathering
the host data and ensures all hosts are included.

Also, only hosts where a matching app was found are output.

Why

References

GEA-249

The script application-detection.gmp.py will now get the report
details and extract the host IP addresses correctly.
@github-actions
Copy link

Conventional Commits Report

Type Number
Changed 1
Bug Fixes 1

🚀 Conventional commits found.

@timopollmeier timopollmeier marked this pull request as ready for review September 28, 2023 10:18
@timopollmeier timopollmeier requested a review from a team as a code owner September 28, 2023 10:18
The application-detection script now requests details for each report
individually with minimum results, which is usually faster for gathering
the host data and ensures all hosts are included.

Also, only hosts where a matching app was found are output.
@timopollmeier timopollmeier merged commit 6f6e2a7 into main Sep 28, 2023
19 checks passed
@timopollmeier timopollmeier deleted the fix-application-detection branch September 28, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants