Skip to content

feat(daffio): add design examples to daff.io #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

damienwebdev
Copy link
Member

@damienwebdev damienwebdev commented May 19, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we have many empty slots for design examples on daff.io, however no examples are rendered.

Fixes: #2903

What is the new behavior?

This allows the app to render these examples.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@damienwebdev damienwebdev requested review from a team as code owners May 19, 2025 14:38
@damienwebdev damienwebdev requested a review from griest024 May 19, 2025 14:38
@damienwebdev damienwebdev marked this pull request as draft May 19, 2025 14:38
@@ -5,7 +5,7 @@ import { RouterModule } from '@angular/router';
import { DaffContainerModule } from '@daffodil/design/container';
import { DaffHeroModule } from '@daffodil/design/hero';
import {
provideDaffDocsDesignExamples,
provideDaffDocsExampleComponents,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damienwebdev @griest024

provideDaffDocsDesignExamples doesn't exist in the codebase, so I assumed it's supposed to be provideDaffDocsDesignExampleComponents. I don't know if this is correct though.

@xelaint xelaint added the package: daff.io @daffodil/daff.io label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Display Example Viewer in Markdown Files
3 participants