Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement issue 2290 (render leisure=resort) #4779

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

GunSmoker
Copy link

Fixes #2290

Almost always people use tourism=camp_site instead of (or in addition to) leisure=resort, because leisure=resort is not rendered, while tourism=camp_site is. Both tourism=camp_site and leisure=resort seems to be very similar, so it would make sense to render (or not render) both.

Changes proposed in this pull request:
Render leisure=resort like a tourism=camp_site, but with the \symbols\leisure\resort.svg icon instead of the tent.

@imagico
Copy link
Collaborator

imagico commented Feb 23, 2023

This lacks a rendering example.

The symbol used seems to be the same as the one for tourism=wilderness_hut - meaning that symbol wise tourism=wilderness_hut and leisure=resort would render the same - which is not a viable approach.

Apart from that my comments in #2290 (comment) still apply. I am not sure what semantic paradigm the rendering of leisure=resort here is meant to communicate and if that is clear it would remain to be seen if mapping widely follows that paradigm.

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a sample rendering so we can review it. Also, can you please squish the commits together and force-push to this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render leisure=resort
3 participants